Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Deleting accesstoken does not delete secret #1919

Closed
calvinbui opened this issue Jan 24, 2025 · 1 comment
Closed

[v2] Deleting accesstoken does not delete secret #1919

calvinbui opened this issue Jan 24, 2025 · 1 comment
Assignees

Comments

@calvinbui
Copy link

Describe the bug

When deleting an accesstoken, the secret remains.

If recreating the accesstoken, this error appears:

Controller could not create received secret: secrets "example" already exists

How To Reproduce

  1. Create accesstoken
  2. Delete accesstoken
  3. Re-create accesstoken with the same name

Expected behavior

The secret is deleted when the accesstoken is deleted

Environment details

  • Skupper CLI: [e.g. 1.5.0, 1.4.3] 2.0.0-preview-2
  • Platform: [e.g kubernetes, openshift] kubernetes

Additional context

@grs
Copy link
Member

grs commented Feb 26, 2025

The lifetime of the Link created from an AccessToken is not tied to the life of the AccessToken. The AccessToken is intended as a temporary object, and once the link has been established it is no longer required (and could be deleted).

The CLI has been improved such that token always have unique names avoiding any issue with the delete/recreate sequence through the CLI.

@grs grs closed this as completed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants