Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight "pending" status because the console url is displayed and might not be available #992

Closed
pwright opened this issue Jan 18, 2023 · 3 comments · May be fixed by #993
Closed

Highlight "pending" status because the console url is displayed and might not be available #992

pwright opened this issue Jan 18, 2023 · 3 comments · May be fixed by #993

Comments

@pwright
Copy link
Member

pwright commented Jan 18, 2023 

$ skupper status
Skupper is enabled for namespace "default" in interior mode. Status pending... It has no exposed services.
The site console url is:  https://10.103.37.45:8080
The credentials for internal console-auth mode are held in secret: 'skupper-console-users'

I missed the pending status and clicked the url, but it wasn't there yet..
Maybe if 'pending' was highlighted with quotes it would help?
@hash-d
Copy link
Member

hash-d commented Jan 18, 2023

I think highlighting 'pending' might be good, but I'd definitely not take the console url out because of skupper status. I don't know all reasons it would be non-ready, but it's conceivable that the console might be up even though skupper as a whole is not, and it could be useful into debugging why it is not.

@pwright pwright mentioned this issue Jan 19, 2023
Open
@pwright pwright changed the title Don't display console url if status is pending Highlight "pending" status because the console url is displayed and might not be available Jan 19, 2023
@pwright
Copy link
Member Author

pwright commented Jan 19, 2023

@hash-d +1 changed issue title

@pwright
Copy link
Member Author

pwright commented Oct 29, 2024

I believe this is being addressed in v2

@pwright pwright closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

highlight "pending" status pwright/skupper
2 participants
@pwright @hash-d