Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to collapse preformatted blocks, configuration option to set default #180

Closed
jamestomasino opened this issue Feb 25, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jamestomasino
Copy link

The preformatted text blocks have an alt text property following the three backticks which is designed to be a human-readable representation or indication of what is in the block. This feature gains value for blind users when our clients embrace it and allow it to be displayed instead of the wall of text common in ascii art or even code samples.

Davin Prater's post on the mailing list explains this from the POV of a blind user quite well.

As a feature request I would ask for two additions to Lagrange to improve it for blind users:

  1. Allow preformatted blocks to toggle visibility, labeled with their alt-text representation or a generic fallback
  2. Allow the collapsed state to be set as the default in a configuration option
@skyjake skyjake added this to the v1.3 milestone Feb 26, 2021
@skyjake skyjake added the enhancement New feature or request label Feb 26, 2021
@skyjake
Copy link
Owner

skyjake commented Feb 26, 2021

I have been wondering what to do with the alt texts beyond the obvious tooltips (that haven't been implemented either)...

Your suggestion sounds like a pretty good approach.

@ghost
Copy link

ghost commented Feb 27, 2021

@jamestomasino mentioned on IRC that they've not specified the generic fallback, in the case that no alt-text is given. I suggest(ed) that a simple 'missing alt-text' or 'no alt-text provided' message be used.

@skyjake skyjake self-assigned this Mar 26, 2021
skyjake added a commit that referenced this issue Mar 28, 2021
The alt text of preformatted blocks is shown on mouse hover.

The blocks can be clicked to toggle folding.

IssueID #180
@skyjake
Copy link
Owner

skyjake commented Mar 29, 2021

  1. Allow preformatted blocks to toggle visibility, labeled with their alt-text representation or a generic fallback
  2. Allow the collapsed state to be set as the default in a configuration option

Both done for v1.3.

additions to Lagrange to improve it for blind users

Mind you, Lagrange is currently completely unusable to blind users because there is no integration whatsoever with screen readers. (This is a separate issue #186.) However, this feature encourages use of alt text in preformatted blocks, so it should still be beneficial overall.

@skyjake skyjake closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants