Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog keyboard navigation (add 'Save Bookmark' to tab cycling in "Add Bookmark" dialog) #231

Closed
GiovanniMoretti opened this issue Mar 29, 2021 · 2 comments
Closed

Dialog keyboard navigation (add 'Save Bookmark' to tab cycling in "Add Bookmark" dialog) #231

GiovanniMoretti opened this issue Mar 29, 2021 · 2 comments
Labels
enhancement New feature or request suggestion Suggestion for future consideration

Comments

@GiovanniMoretti
Copy link

Currently, the Tab key cycles through the Title/URL/Tags/Icon fields - using the mouse is necessary to do the save.

Suggestions: in the "Add Bookmark" dialog:

  • Add "Save" and then "Cancel" to the tab cycling; in that order as most of the time Save is probably the wanted option.
  • Make Esc cancel the dialog immediately (as usual). Not sure why but currently two presses are required.
@skyjake skyjake added suggestion Suggestion for future consideration enhancement New feature or request labels Mar 29, 2021
@skyjake
Copy link
Owner

skyjake commented Mar 29, 2021 •
edited
Loading

I agree the UX is a bit questionable here. The Save button actually does have a keyboard shortcut: Ctrl+Return on Windows/Linux, and ⌘⏎ on the Mac. I'll consider making the shortcut visible in the button for clarity.

The double Esc is happening because the first Esc clears the input focus, while the second one actually cancels the dialog. It would make more sense to dismiss the whole dialog on the first Esc.

Keyboard-navigable UI focus, e.g., allowing the input focus to move onto buttons, is a larger topic that needs to be considered in the scope of the entire app UI. (There's also #144.)

@skyjake skyjake changed the title Add 'Save Bookmark' to tab cycling in "Add Bookmark" dialog Dialog keyboard navigation (add 'Save Bookmark' to tab cycling in "Add Bookmark" dialog) Sep 18, 2021
skyjake added a commit that referenced this issue Sep 19, 2021
@skyjake
Focus cycling with Tab includes buttons
70bdd01 
Tab/⇧Tab can be used to switch focus to any button in addition to input fields. The focused button can be activated by pressing Space or Return.

TODO: Dropdown menus get dismissed prematurely when trying to switch focus.

IssueID #231
@skyjake
Copy link
Owner

skyjake commented Nov 2, 2021

Focus cycling to dialog buttons has been implemented.

@skyjake skyjake closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request suggestion Suggestion for future consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiovanniMoretti @skyjake