Rename config files -> file name remains old in log statements until reboot of intelliJ

[zzeekk]

When i rename a config file, interestingly in the lsp log there are new messages with the old filename, until i restart IntelliJ.
Restarting only the LSP server is not enough.
Is there are reason for this?

[dsalathe]

I don't have a solution for this bug but I can explain what's happening: Renaming a file doesn't trigger any LSP events. Unsure if it is a bug of LSP4IJ or if it is simply not handled in the LSP protocol. Further events keep the old name.
If we restart LSP4IJ, events will keep the old name, duplicating the file entry in the LSP server, because when initializing the server, we read the current names written in the user's filesystem.

This may cause issue as the old file will keep leaving in the Server's workspace. For now, only restarting Intellij fixes the issue indeed.

[angelozerr]

Is you server defines file Watchers?

[dsalathe]

@angelozerr thanks for the pointer. No indeed, will have a look at that 😄

[angelozerr]

I think it is a bug from LSP4IJ,.I am fixing it.

I will ping you when you will able to test my fix

[angelozerr]

@zzeekk could you install https://github.com/redhat-developer/lsp4ij?tab=readme-ov-file#testing-nightly-builds and tell me if it fixes your issue.

Thanks!

[zzeekk]

Hi @angelozerr, thanks for looking into this.

I tested with the latest nightly release. Now after renaming i have both files in the context. I can even delete some content from the renamed file, and still get completions from the old file...

Logs (i renamed airports.conf ->airports12.conf):

20:04:54.607 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - Insertion: Checking context for file:///C:/projects/git/getting-started/config/airports12.conf
20:04:54.645 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - New context detected: Workspace(file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf,HashMap(
file:///C:/projects/git/getting-started/config/airports.conf -> SDLBContext(TextContext(originalText=
...
, file:///C:/projects/git/getting-started/config/airports12.conf -> 
# This is the airports.conf file as it should look after completing part-3b
...

[angelozerr]

It means that it is working?

[angelozerr]

@zzeekk please note that you can use LSP console https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#lsp-console to show LSP traces easily.

[zzeekk]

Here the LSP traces. Interestingly there is still "airports.conf" in the second last message:

[Trace - 21:10:46] Sending notification 'textDocument/didClose'
Params: {
  "textDocument": {
    "uri": "file:///C:/projects/git/getting-started/config/airports.conf"
  }
}

[Trace - 21:10:46] Sending notification 'textDocument/didOpen'
Params: {
  "textDocument": {
    "uri": "file:///C:/projects/git/getting-started/config/airports12.conf",
    "languageId": "hocon",
    "version": 1,
    "text": ...
  }
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 3,
  "message": "21:10:45.838 [pool-1-thread-1] INFO  i.s.l.SmartDataLakeTextDocumentService - Detecting deletion of file:///C:/projects/git/getting-started/config/airports.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.839 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - Updating context for file:///C:/projects/git/getting-started/config/airports.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.849 [pool-1-thread-1] TRACE i.s.l.workspace.Workspace - Updating all contexts (5) of workspace file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.851 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - Insertion: Checking context for file:///C:/projects/git/getting-started/config/airports12.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.876 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - New context detected: Workspace(file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf,HashMap(file:///C:/projects/git/getting-started/config/airports.conf ...
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.886 [pool-1-thread-1] TRACE i.s.l.workspace.Workspace - Updating all contexts (6) of workspace file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf"
}

[angelozerr]

Here the LSP traces. Interestingly there is still "airports.conf" in the second last message:

[Trace - 21:10:46] Sending notification 'textDocument/didClose'
Params: {
  "textDocument": {
    "uri": "file:///C:/projects/git/getting-started/config/airports.conf"
  }
}

[Trace - 21:10:46] Sending notification 'textDocument/didOpen'
Params: {
  "textDocument": {
    "uri": "file:///C:/projects/git/getting-started/config/airports12.conf",
    "languageId": "hocon",
    "version": 1,
    "text": ...
  }
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 3,
  "message": "21:10:45.838 [pool-1-thread-1] INFO  i.s.l.SmartDataLakeTextDocumentService - Detecting deletion of file:///C:/projects/git/getting-started/config/airports.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.839 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - Updating context for file:///C:/projects/git/getting-started/config/airports.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.849 [pool-1-thread-1] TRACE i.s.l.workspace.Workspace - Updating all contexts (5) of workspace file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.851 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - Insertion: Checking context for file:///C:/projects/git/getting-started/config/airports12.conf"
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.876 [pool-1-thread-1] TRACE i.s.l.SmartDataLakeTextDocumentService - New context detected: Workspace(file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf,HashMap(file:///C:/projects/git/getting-started/config/airports.conf ...
}

[Trace - 21:10:46] Received notification 'window/logMessage'
Params: {
  "type": 4,
  "message": "21:10:45.886 [pool-1-thread-1] TRACE i.s.l.workspace.Workspace - Updating all contexts (6) of workspace file:///C:/projects/git/getting-started/config,file:///C:/projects/git/getting-started/envConfig/dev.conf"
}

Lsp traces with didClose and didOpen sent by lsp4ij seems correct

The other trace are logs coming from the language server.

I cannot help you about that

[dsalathe]

@angelozerr Many thanks for your help.
@zzeekk I confirm what Angelo said, what remains in the logs are 'logMessage' events that show the old file is still in the workspace, but normally its content should actually be cleared. I will run further test to confirm this, but to me it looks good.

[angelozerr]

@angelozerr Many thanks for your help.
@zzeekk I confirm what Angelo said, what remains in the logs are 'logMessage' events that show the old file is still in the workspace, but normally its content should actually be cleared. I will run further test to confirm this, but to me it looks good.

@dsalathe I suggest that you integrate your ls in vscode to check if there is the same problem with LSP4IJ to now if problem comes from LSP4IJ or from your language server

If it works with vscode please let me know and I will study more why there is this issue.