Skip to content

fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fruity-kings-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": patch
---

fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd
31 changes: 17 additions & 14 deletions engine/cld/legacy/cli/mcmsv2/mcms_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ func BuildMCMSv2Cmd(lggr logger.Logger, domain cldf_domain.Domain, proposalConte
validProposalKinds = []string{string(types.KindProposal), string(types.KindTimelockProposal)}
)

if lggr == nil {
panic("nil logger received")
}
if proposalContextProvider == nil {
panic("nil proposal context provider received")
}

cmd := cobra.Command{
Use: "mcmsv2",
Short: "Manage MCMS proposals",
Expand Down Expand Up @@ -1097,20 +1104,16 @@ func newCfgv2(lggr logger.Logger, cmd *cobra.Command, domain cldf_domain.Domain,
}
}

if proposalCtxProvider != nil {
// Load Environment and proposal ctx (for error decoding and proposal analysis)
env, err := cldfenvironment.Load(cmd.Context(), domain, cfg.envStr,
cldfenvironment.WithLogger(lggr),
cldfenvironment.OnlyLoadChainsFor(chainSelectors), cldfenvironment.WithoutJD())
if err != nil {
return nil, fmt.Errorf("error loading environment: %w", err)
}
cfg.env = env
proposalCtx, err := proposalCtxProvider(env)
if err != nil {
return nil, fmt.Errorf("failed to provide proposal analysis context: %w", err)
}
cfg.proposalCtx = proposalCtx
// Load Environment and proposal ctx (for error decoding and proposal analysis)
cfg.env, err = cldfenvironment.Load(cmd.Context(), domain, cfg.envStr,
cldfenvironment.WithLogger(lggr),
cldfenvironment.OnlyLoadChainsFor(chainSelectors), cldfenvironment.WithoutJD())
if err != nil {
return nil, fmt.Errorf("error loading environment: %w", err)
}
cfg.proposalCtx, err = proposalCtxProvider(cfg.env)
if err != nil {
return nil, fmt.Errorf("failed to provide proposal analysis context: %w", err)
}

if flags.fork {
Expand Down