Skip to content

Commit b7d893c

Browse files
Implemented logic of GetInteriorVehicleData according to proposal
1 parent b448853 commit b7d893c

File tree

1 file changed

+31
-22
lines changed

1 file changed

+31
-22
lines changed

ffw/RCRPC.js

Lines changed: 31 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -222,54 +222,63 @@ FFW.RC = FFW.RPCObserver.create(
222222
case 'RC.GetInteriorVehicleData':
223223
{
224224
Em.Logger.log('FFW.' + request.method + 'Response');
225-
if (!this.conssetAppCheck(request)) {
226-
return;
225+
if (request.params.appID == undefined) {
226+
this.sendError(
227+
SDL.SDLModel.data.resultCode.INVALID_DATA, request.id,
228+
request.method, 'appID parameter missing!'
229+
);
230+
return;
227231
}
228-
if (request.params.moduleDescription == undefined) {
229-
this.sendError(
230-
SDL.SDLModel.data.resultCode.REJECTED, request.id,
231-
request.method, 'ModuleDescription parameter missing!'
232-
);
232+
if (!this.conssetAppCheck(request)) {
233233
return;
234234
}
235-
var radioControlData = null;
235+
236+
var moduleType = request.params.moduleDescription.moduleType;
237+
var moduleName = null;
236238
var climateControlData = null;
239+
var radioControlData = null;
240+
237241
var app = SDL.SDLController.getApplicationModel(
238242
request.params.appID
239243
);
240-
app.moduleSubscriptions[request.params.moduleDescription.moduleType].subscription
241-
= request.params.subscribe;
242-
if (request.params.moduleDescription.moduleType === 'CLIMATE') {
243-
climateControlData = SDL.ClimateController.model.climateControlData;
244-
} else if (request.params.moduleDescription.moduleType ===
245-
'RADIO') {
246-
radioControlData = SDL.RadioModel.get('radioControlData');
244+
if (request.params.subscribe !== undefined) {
245+
app.moduleSubscriptions[moduleType].subscription =
246+
request.params.subscribe;
247247
}
248-
// send repsonse
248+
if (moduleType === 'CLIMATE') {
249+
moduleName = SDL.ClimateController.model.getModuleName();
250+
climateControlData = SDL.ClimateController.model.getClimateControlData();
251+
} else if (moduleType === 'RADIO') {
252+
moduleName = SDL.RadioModel.getModuleName();
253+
radioControlData = SDL.RadioModel.getRadioControlData();
254+
}
255+
249256
var JSONMessage = {
250257
'jsonrpc': '2.0',
251258
'id': request.id,
252259
'result': {
253260
'code': SDL.SDLModel.data.resultCode.SUCCESS,
254261
'method': request.method,
255262
'moduleData': {
256-
'moduleType': request.params.moduleDescription.moduleType
263+
'moduleType': moduleType,
264+
'moduleName': moduleName
257265
}
258266
}
259267
};
268+
260269
if (radioControlData) {
261-
JSONMessage.result.moduleData.radioControlData = radioControlData;
270+
JSONMessage.result.moduleData.radioControlData =
271+
radioControlData;
262272
}
263273
if (climateControlData) {
264-
climateControlData = SDL.SDLController.correctTemp(
265-
climateControlData, 'get'
266-
);
267274
JSONMessage.result.moduleData.climateControlData
268275
= climateControlData;
269276
}
270277
if (request.params.subscribe !== undefined) {
271-
JSONMessage.result.isSubscribed = request.params.subscribe;
278+
JSONMessage.result.isSubscribed =
279+
app.moduleSubscriptions[moduleType].subscription;
272280
}
281+
273282
this.client.send(JSONMessage);
274283
break;
275284
}

0 commit comments

Comments
 (0)