Merge branch 'release/4.4.0-rc1' of https://github.com/smartdevicelink/sdl_android

Author: joeygrover

CONTRIBUTING.md renamed to .github/CONTRIBUTING.md

@@ -0,0 +1,23 @@
+[Delete any non-applicable sections, but we may ask for more information.]
+
+### Bug Report
+[Summary]
+
+##### Reproduction Steps
+1. [Step 1]
+2. [Step 2]
+3. [Step 3]
+
+##### Expected Behavior
+[Some expected behavior]
+
+##### Observed Behavior
+[Some observed behavior]
+
+##### OS & Version Information
+* Android Version: [What version of Android are you using when the bug occurred]
+* SDL Android Version: [What version of the library has this bug been seen on]
+* Testing Against: [What you tested with to observe this behavior]
+
+##### Test Case, Sample Code, and / or Example App
+[Paste a link to a PR, gist, or other code that exemplifies this behavior]

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,33 @@
+[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_android/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA.
+
+Delete the above section when you've read it.]
+
+Fixes #[issue number]
+
+This PR is **[ready / not ready]** for review.
+
+### Risk
+This PR makes **[no / minor / major]** API changes.
+
+### Testing Plan
+[Describe how you plan to unit test the changes in this PR]
+
+### Summary
+[Summary of PR changes]
+
+### Changelog
+##### Breaking Changes
+* [Breaking change info]
+
+##### Enhancements
+* [Enhancement info]
+
+##### Bug Fixes
+* [Bug Fix Info]
+
+### Tasks Remaining:
+- [ ] [Task 1]
+- [ ] [Task 2]
+
+### CLA
+- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,18 +4,30 @@ sudo: false
 android:
   components:
     # use the latest revision of Android SDK Tools
-    - platform-tools
     - tools
+    - tools
+    - platform-tools
+    - ndk-bundle
 
     # The BuildTools version used by your project
-    - build-tools-25.0.2
+    - build-tools-26.0.1
 
     # The SDK version used to compile your project
-    - android-19
+    - android-26
+    - android-22 #For emulator
     # Specify at least one system image,
     # if you need to run emulator(s) during your tests
-    - sys-img-armeabi-v7a-android-21
-    # - sys-img-x86-android-17
+    - sys-img-armeabi-v7a-android-22
+    # - sys-img-x86-android-26
+
+    # Android Support Repos
+    - extra-android-m2repository
+    - extra-google-m2repository
+
+licenses:
+    - 'android-sdk-preview-license-.+'
+    - 'android-sdk-license-.+'
+    - 'google-gdk-license-.+'
 
 env:
   global:
@@ -24,11 +36,17 @@ env:
 
 # Emulator Management: Create, Start and Wait
 before_script:
-  - echo no | android create avd --force -n test -t android-21 --abi armeabi-v7a
+  - echo no | android create avd --force -n test -t android-22 --abi armeabi-v7a
   - emulator -avd test -no-skin -no-audio -no-window &
   - android-wait-for-emulator
   - adb shell input keyevent 82 &
 
 script:
   - android list target
   - ./gradlew connectedAndroidTest
+
+before_install:
+    - pip install --user codecov    #Install codecov
+
+after_success:
+    - codecov                       #Run codecov

.travis.yml

@@ -1,37 +1,48 @@
-# 4.3.0 Release Notes
+# 4.4.0 Release Notes
 
 ### API New Features & Breaking Changes
-* The library has now moved to Android Studio as its default IDE. All files and folders have been moved to align with proper Android Studio project structure.
-* The target API level is now `19` instead of `18`. Apps will also need to target this version or higher to continue using this library.
-* `Java 7` is now used to compile the library and its features can be used moving forward. 
+- Now uses compile version 26 to handle breaking changes in Android Oreo
+- `MOBILE_PROJECTION` added as an app type
+- Gesture cancellation was added as a touch even type
+- More languages were added to the `Language` enum
+- `SystemCapaibilityQuery` was added with a new `SystemCapabilityManager` that can retrieve capabilities
+- `VideoStreamingCapabilities` were added. Includes supported codecs, resolution, etc
+- Added constructed payloads using BSON
+- SDL Remote Control functionality was added. Supports radio and climate controls.
+- Added `MetadataType` to `Show` lines
+- Spatial data for video streaming apps added with `HapticData`
+
 
 ### Enhancements
-* Multiplexing bluetooth, legacy bluetooth, and TCP transport has been improved in performance by switching to buffer reads vs single byte read from transport.
-* Trusted router service checking feature is now adjustable by developers. 
-* More unit tests were created.
-* Router service will now check to make sure the app that propagated it has permissions to use bluetooth. 
-* Packet streaming classes will now use the agreed upon MTU instead of the hardcoded 1024 when the stream is not encrypted.
-* App IDs sent between the client apps and the router service are now Strings instead of Longs to support longer IDs.
+- Enhanced video streaming APIs
+- Added much more test coverage
+- Updated buffer read in sizes and streaming packetizers to use TLS max record size
+- Consolidated all references to `sdl.router.startservice` string into single constant
+- Refactored RPC classes to consolidate redundant code for retrieving items from underlying data structures
+- `MultiplexBluetoothTransport` is no longer a singleton
+- Improved inline documentation
+- h.264 streaming now includes SPS/PPS NAL units with every I frame to match iOS library
+- Real-time Transport Protocol (RTP) video streaming is now supported
+- Correlation IDs are now set automatically. Can be retrieved or overwritten by developer.
+- Introduced new video streaming callback and deprecated used of pipped streams
+- Added an internal interface for common functions between different managers
 
 ### Bug Fixes
-* Fixed issue with AOA transport not clearing old accessory reference after disconnect
-* Fixed missing setting of error state in multiplexing bluetooth transport
-* Fixed potential OOMs when corrupted packets are recieved in:
- *  `SdlPsm`
- *  `WiProProtocol`
- *  `BinaryFrameHeader`
-* Fixed possible NPEs in:
- * `SdlRouterService` when checking for correct process
- * `MultiplexingBluetoothTransport` during reads and writes
- * `SdlConnection` during session registration
- * `SdlProxyBase` when clearing RPC response and notification listeners during close 
- * `TransportBroker` when sending a message to router service
- * `SdlBroadcastReceiver` during check for running router service
- * `HttpRequestTask` that happens when a server can't be reached
- * `SdlSecurityBase` when a security lib would become initialized after the base has been reset. 
-* Added synchronization to a cancel call in the `MultiplexTransport`
-* Refactor code in `SdlBroadcastReceiver` to protect against a potential SecurityException
-* Added try/catch around bluetooth system calls that can fail in Android classes
-* Added try/catch when attempting to build `LocalRouterService` object from parcel when parcel could be corrupt
-* Fixed version checking flow in the router service to be cleaner and correctly synched
+- Fixed potential out of bounds exception in `BinaryFrameHeader` 
+- Fixed issues with unit tests and TravisCI
+- Fixed potential NPE in `SdlProxyBase`method, `performBaseCommon()` 
+- Fixed potential NPE in `MultiplexTransport` constructor 
+- Fixed potential NPE in `SdlRouterService`method, `handleMessaage()` for `AltTransportHandler` 
+- Fixed potential NPE in `SdlRouterService`method, `writeBytesToTransport()`
+- Removed hardcoded `androidDebuggable = "true"` from manifest
+- Added fixes to be compatible with Android Oreo (Does not supported target API level 26 yet)
+- Fixed issue where intent from router service was delayed
+- Apps now trust themselves as router service hosts
+- Removed ambiguous validation call in `SdlBroadcastReceiver` and unused intent extra
+- Cleared all warnings from `SdlProxyBase`
 
+### Meta
+- Added integration that will deploy to Bintray
+- Issue and pull request templates were added for GitHub
+- Codecov integration was added
+- Updated README links

CHANGELOG.md

@@ -1,4 +1,7 @@
+[![Build Status](https://travis-ci.org/smartdevicelink/sdl_android.svg?branch=master)](https://travis-ci.org/smartdevicelink/sdl_android)
+[![codecov](https://codecov.io/gh/smartdevicelink/sdl_android/branch/master/graph/badge.svg)](https://codecov.io/gh/smartdevicelink/sdl_android)
 [![Slack Status](http://sdlslack.herokuapp.com/badge.svg)](http://slack.smartdevicelink.com)
+[ ![Download](https://api.bintray.com/packages/smartdevicelink/sdl_android/sdl_android/images/download.svg) ](https://bintray.com/smartdevicelink/sdl_android/sdl_android/_latestVersion)
 # SmartDeviceLink (SDL)
 
 SmartDeviceLink (SDL) is a standard set of protocols and messages that connect applications on a smartphone to a vehicle head unit. This messaging enables a consumer to interact with their application using common in-vehicle interfaces such as a touch screen display, embedded voice recognition, steering wheel controls and various vehicle knobs and buttons. There are three main components that make up the SDL ecosystem.
@@ -19,6 +22,8 @@ The mobile library component of SDL is meant to run on the end user’s smart-de
 
 ## SmartDeviceLink Android
 
-We're still working on creating documentation for each of these individual repositories, but in the meantime, you can find more information about SmartDeviceLink [here](https://github.com/smartdevicelink/sdl_core/blob/master/README.md) and [here](http://projects.genivi.org/smartdevicelink/about).
+We're still working on creating documentation for each of these individual repositories, but in the meantime, you can find more information about SmartDeviceLink [here](https://smartdevicelink.com)
 
 You can also find some branches that have yet to be merged into this GitHub project on the GENIVI page [here](http://git.projects.genivi.org/?p=smartdevicelink_android.git;a=summary).
+
+For easy integration of SmartDeviceLink Android into your project using Gradle, Maven or Ivy please grab a snippet from [Bintray](https://bintray.com/smartdevicelink/sdl_android/sdl_android)

README.md

@@ -0,0 +1,71 @@
+apply plugin: "com.jfrog.bintray"
+apply plugin: 'com.github.dcendents.android-maven'
+apply plugin: 'maven-publish'
+
+def siteUrl = 'https://github.com/smartdevicelink/sdl_android'      // Homepage URL of the library
+def gitUrl = 'https://github.com/smartdevicelink/sdl_android.git'   // Git repository URL
+group = "com.smartdevicelink" // Maven Group ID for the artifact
+def libDescription = 'SmartDeviceLink mobile library for Android'
+
+install {
+    repositories.mavenInstaller {
+        pom {
+            project {
+                packaging 'aar'
+
+                // Add your description here
+                name 'com.smartdevicelink:sdl_android'
+                description = libDescription
+                url siteUrl
+
+                // Set your license
+                licenses {
+                    license {
+                        name 'BSD 3-Clause'
+                        url 'https://opensource.org/licenses/BSD-3-Clause'
+                    }
+                }
+                scm {
+                    connection gitUrl
+                    developerConnection gitUrl
+                    url siteUrl
+                }
+            }
+        }
+    }
+}
+
+task sourcesJar(type: Jar) {
+    from android.sourceSets.main.java.srcDirs
+    classifier = 'sources'
+}
+
+artifacts {
+    archives sourcesJar
+}
+
+bintray {
+    Properties props = new Properties()
+    props.load(new FileInputStream("$projectDir/bintray.properties"))
+
+    // Authorization
+    user = props.getProperty("bintray.user")
+    key = props.getProperty("bintray.key")
+
+    configurations = ['archives']
+    pkg {
+        repo = props.getProperty("bintray.repo")
+        name = props.getProperty("bintray.artifact")
+        websiteUrl = siteUrl
+        vcsUrl = gitUrl
+        userOrg = props.getProperty("bintray.userorg")
+        licenses = ["BSD 3-Clause"]
+        publish = props.getProperty("bintray.publish")  // Will upload to jCenter
+        version {
+            name = props.getProperty("bintray.version")  // Change to release version
+            desc = libDescription
+            released  = new Date()  // Will be the current date & time
+            vcsTag = props.getProperty("bintray.vcs") // Should match git tag
+        }
+    }
+}

sdl_android/bintray.gradle

@@ -0,0 +1,8 @@
+bintray.user=username
+bintray.key=apikey
+bintray.repo=sdl_android
+bintray.artifact=sdl_android
+bintray.userorg=smartdevicelink
+bintray.publish=true
+bintray.version=X.X.X
+bintray.vcs=X.X.X

sdl_android/bintray.properties

@@ -1,7 +1,7 @@
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 19
+    compileSdkVersion 26
     buildToolsVersion "25.0.2"
     defaultConfig {
         minSdkVersion 8
@@ -15,6 +15,9 @@ android {
             minifyEnabled false
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
+        debug {
+            testCoverageEnabled = true
+        }
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_7
@@ -23,12 +26,36 @@ android {
     lintOptions {
         abortOnError false
     }
+
+    testOptions {
+        unitTests.returnDefaultValues = true
+    }
 }
 
 dependencies {
     compile fileTree(dir: 'libs', include: ['*.jar'])
+    compile ('com.smartdevicelink:bson_java_port:1.0.0@aar'){
+        transitive = true
+    }
     androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
         exclude group: 'com.android.support', module: 'support-annotations'
     })
     testCompile 'junit:junit:4.12'
+    testCompile 'org.mockito:mockito-core:2.9.0'
+    
 }
+
+buildscript {
+    repositories {
+        jcenter()
+        mavenCentral()
+    }
+    dependencies {
+        classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7.3'
+        classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'
+        classpath 'com.trickyandroid:jacoco-everywhere:0.2.1'
+    }
+}
+
+apply from: 'bintray.gradle'
+apply plugin: 'jacoco-everywhere'

sdl_android/build.gradle

@@ -0,0 +1,15 @@
+{
+  "request":{
+    "name":"ButtonPress",
+    "correlationID":215,
+    "parameters":{
+      "buttonName":"OK",
+      "buttonPressMode":"LONG",
+      "moduleType":"CLIMATE"
+    }
+  },
+  "response":{
+    "name":"ButtonPressResponse",
+    "correlationID":216
+  }
+}