Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SdlTransport.handleTransportError() is not thread safe #429

Open
chenbd opened this issue Feb 16, 2017 · 0 comments
Open

SdlTransport.handleTransportError() is not thread safe #429

chenbd opened this issue Feb 16, 2017 · 0 comments
Labels
bug A defect in the library transport-bluetooth Relating to the BT transport transport-tcp Relating to the primary TCP transport transport-usb Relating to the USB transport

Comments

@chenbd
Copy link

chenbd commented Feb 16, 2017

SdlTransport.handleTransportError() may be called from different thread.
in handleTransportError(), _transportListener.onTransportError() will be called which cause _transportListener need consider synchronized and may cause some issues.

guess _transportListener's call back should be called in dedicated thread.

https://github.com/smartdevicelink/sdl_android/blob/develop/sdl_android_lib/src/com/smartdevicelink/transport/SdlTransport.java#L103-L107

@joeljfischer joeljfischer added bug A defect in the library transport-tcp Relating to the primary TCP transport transport-usb Relating to the USB transport transport-bluetooth Relating to the BT transport labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library transport-bluetooth Relating to the BT transport transport-tcp Relating to the primary TCP transport transport-usb Relating to the USB transport
Projects
None yet
Development

No branches or pull requests

2 participants