Skip to content

Show audio bitrate only for audio only files #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basicmaster wants to merge 1 commit into from
Closed

Show audio bitrate only for audio only files #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3880,13 +3880,13 @@ void Core::gotStartingTime(double time) {
void Core::gotVideoBitrate(int b) {
//qDebug("Core::gotVideoBitrate: %d", b);
mdat.video_bitrate = b;
emit bitrateChanged(mdat.video_bitrate, mdat.audio_bitrate);
emit bitrateChanged(!mdat.novideo ? mdat.video_bitrate : -1, mdat.audio_bitrate);
}

void Core::gotAudioBitrate(int b) {
//qDebug("Core::gotAudioBitrate: %d", b);
mdat.audio_bitrate = b;
emit bitrateChanged(mdat.video_bitrate, mdat.audio_bitrate);
emit bitrateChanged(!mdat.novideo ? mdat.video_bitrate : -1, mdat.audio_bitrate);
}

void Core::gotDemuxRotation(int r) {
Expand Down
5 changes: 4 additions & 1 deletion src/defaultgui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,10 @@ void DefaultGui::displayVideoInfo(int width, int height, double fps) {
}

void DefaultGui::displayBitrateInfo(int vbitrate, int abitrate) {
bitrate_info_display->setText(tr("V: %1 kbps A: %2 kbps").arg(qRound(vbitrate/1000.0)).arg(qRound(abitrate/1000.0)));
QString text = tr("V: %1 kbps A: %2 kbps").arg(qRound(vbitrate/1000.0)).arg(qRound(abitrate/1000.0));
// if no video, display audio bitrate only (just cutting off the video part, to avoid an additional translation string)
if (vbitrate == -1) text = text.remove(QRegularExpression("^V: .* A: "));
bitrate_info_display->setText(text);
}

void DefaultGui::updateWidgets() {
Expand Down