Fixes dynamic property deprecations

maciejlew · maciejlew · commit 91cd562487b3 · 2022-11-16T13:58:13.000+01:00
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -9,7 +9,7 @@ on:
 
 jobs:
     tests:
-        name: PHP ${{ matrix.php }} / ${{ matrix.dependency-version }}
+        name: PHP ${{ matrix.php }}
         runs-on: ubuntu-latest
         strategy:
             matrix:
@@ -37,10 +37,41 @@ jobs:
                 uses: actions/cache@v2
                 with:
                     path: ${{ steps.composer-cache.outputs.dir }}
-                    key: composer-${{ runner.os }}-${{ matrix.php }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
+                    key: composer-${{ runner.os }}-${{ matrix.php }}-${{ hashFiles('composer.json') }}
 
             -   name: Install dependencies
                 run: composer update --prefer-dist --no-interaction
 
             -   name: Running unit tests
                 run: php vendor/bin/phpunit --configuration tests-resources/phpunit.dist.xml --testsuite unit
+
+    tests-rc:
+        name: PHP ${{ matrix.php }}
+        runs-on: ubuntu-latest
+        strategy:
+            matrix:
+                php:
+                    - 8.2
+        steps:
+            -   name: Checkout
+                uses: actions/checkout@v2
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: ${{ matrix.php }}
+
+            -   id: composer-cache
+                run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+            -   name: Cache Composer dependencies
+                uses: actions/cache@v2
+                with:
+                    path: ${{ steps.composer-cache.outputs.dir }}
+                    key: composer-${{ runner.os }}-${{ matrix.php }}-${{ hashFiles('composer.json') }}
+
+            -   name: Install dependencies
+                run: composer update --prefer-dist --no-interaction --ignore-platform-req=PHP
+
+            -   name: Running unit tests
+                run: php vendor/bin/phpunit --configuration tests-resources/phpunit.dist.xml --testsuite unit
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- dynamic property deprecations
 
 ## [3.0.6] - 2022-03-28
 ### Fixed
diff --git a/build/Makefile b/build/Makefile
@@ -7,6 +7,7 @@ include $(CURDIR)/php-7.3/Makefile
 include $(CURDIR)/php-7.4/Makefile
 include $(CURDIR)/php-8.0/Makefile
 include $(CURDIR)/php-8.1/Makefile
+include $(CURDIR)/php-8.2/Makefile
 
 help:
 	@grep -hE '^[a-zA-Z0-9_.-]+:.*?## .*$$' $(MAKEFILE_LIST) \
@@ -24,6 +25,7 @@ test: ## test all against all php images
 	$(MAKE) test-php-7.4
 	$(MAKE) test-php-8.0
 	$(MAKE) test-php-8.1
+	$(MAKE) test-php-8.2
 
 test-unit: ## test unit suite against all php images
 	$(MAKE) test-suite-php-7.0 SUITE=unit
@@ -33,5 +35,6 @@ test-unit: ## test unit suite against all php images
 	$(MAKE) test-suite-php-7.4 SUITE=unit
 	$(MAKE) test-suite-php-8.0 SUITE=unit
 	$(MAKE) test-suite-php-8.1 SUITE=unit
+	$(MAKE) test-suite-php-8.2 SUITE=unit
 
 .DEFAULT_GOAL := help
diff --git a/build/docker-compose.yml b/build/docker-compose.yml
@@ -49,4 +49,11 @@ services:
       context: php-8.1
     volumes:
       - ..:/app
+    network_mode: host
+
+  php-8.2:
+    build:
+      context: php-8.2
+    volumes:
+      - ..:/app
     network_mode: host
diff --git a/build/php-8.2/Dockerfile b/build/php-8.2/Dockerfile
@@ -0,0 +1,18 @@
+FROM composer:latest as composer
+FROM php:8.2-rc-cli-alpine
+
+RUN apk update && \
+    apk upgrade && \
+    apk add --no-cache \
+        autoconf \
+        g++ \
+        make \
+        linux-headers
+
+RUN pecl install xdebug-3.2.0RC2 && \
+    pecl clear-cache && \
+    docker-php-ext-enable xdebug
+
+COPY --from=composer /usr/bin/composer /usr/bin/composer
+
+WORKDIR /app/
diff --git a/build/php-8.2/Makefile b/build/php-8.2/Makefile
@@ -0,0 +1,10 @@
+.PHONY: prepare-php-8.2 test-php-8.2 test-suite-php-8.2
+
+prepare-php-8.2: ## load dependencies with php 8.2
+	docker-compose run -T php-8.2 /usr/bin/composer update --ignore-platform-req=PHP
+
+test-php-8.2: prepare-php-8.2 ## run tests against php 8.2
+	docker-compose run -T php-8.2 php vendor/bin/phpunit --configuration tests-resources/phpunit.xml
+
+test-suite-php-8.2: prepare-php-8.2 ## run suite tests against php 8.2, ex: make test-suite-php-8.2 SUITE="unit"
+	docker-compose run -T php-8.2 php vendor/bin/phpunit --configuration tests-resources/phpunit.xml --testsuite $(SUITE)
diff --git a/composer.json b/composer.json
@@ -16,7 +16,7 @@
         }
     },
     "require": {
-        "php": "^7 || ~8.0 || ~8.1",
+        "php": "^7 || ~8.0 || ~8.1 || ~8.2",
         "ext-json": "*",
         "psr/log": "^1 || ^2 || ^3",
         "psr/http-message": "^1",
diff --git a/src/Feature/Blacklist/Bag/CreateBlacklistedPhoneNumberBag.php b/src/Feature/Blacklist/Bag/CreateBlacklistedPhoneNumberBag.php
@@ -10,6 +10,7 @@
  * @api
  * @property DateTimeInterface $expireAt
  */
+#[\AllowDynamicProperties]
 class CreateBlacklistedPhoneNumberBag
 {
     /** @var string */
diff --git a/src/Feature/Blacklist/Bag/DeleteBlacklistedPhoneNumberBag.php b/src/Feature/Blacklist/Bag/DeleteBlacklistedPhoneNumberBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class DeleteBlacklistedPhoneNumberBag
 {
     /** @var string */
diff --git a/src/Feature/Blacklist/Bag/FindBlacklistedPhoneNumbersBag.php b/src/Feature/Blacklist/Bag/FindBlacklistedPhoneNumbersBag.php
@@ -10,6 +10,7 @@
  * @api
  * @property string $q
  */
+#[\AllowDynamicProperties]
 class FindBlacklistedPhoneNumbersBag
 {
     use PaginationBag;
diff --git a/src/Feature/Contacts/Bag/CreateContactBag.php b/src/Feature/Contacts/Bag/CreateContactBag.php
@@ -16,6 +16,7 @@
  * @property string $city
  * @property string $source
  */
+#[\AllowDynamicProperties]
 class CreateContactBag
 {
     /**
diff --git a/src/Feature/Contacts/Bag/DeleteContactBag.php b/src/Feature/Contacts/Bag/DeleteContactBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class DeleteContactBag
 {
 
diff --git a/src/Feature/Contacts/Bag/FindContactBag.php b/src/Feature/Contacts/Bag/FindContactBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindContactBag
 {
 
diff --git a/src/Feature/Contacts/Bag/FindContactsBag.php b/src/Feature/Contacts/Bag/FindContactsBag.php
@@ -18,6 +18,7 @@
  * @property string $gender
  * @property string $birthdayDate
  */
+#[\AllowDynamicProperties]
 class FindContactsBag
 {
     use PaginationBag;
diff --git a/src/Feature/Contacts/Bag/UpdateContactBag.php b/src/Feature/Contacts/Bag/UpdateContactBag.php
@@ -16,6 +16,7 @@
  * @property string $city
  * @property string $source
  */
+#[\AllowDynamicProperties]
 class UpdateContactBag
 {
 
diff --git a/src/Feature/Contacts/Fields/Bag/CreateContactFieldBag.php b/src/Feature/Contacts/Fields/Bag/CreateContactFieldBag.php
@@ -8,6 +8,7 @@
  * @api
  * @property string $type
  */
+#[\AllowDynamicProperties]
 class CreateContactFieldBag
 {
 
diff --git a/src/Feature/Contacts/Fields/Bag/DeleteContactFieldBag.php b/src/Feature/Contacts/Fields/Bag/DeleteContactFieldBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class DeleteContactFieldBag
 {
 
diff --git a/src/Feature/Contacts/Fields/Bag/FindContactFieldOptionsBag.php b/src/Feature/Contacts/Fields/Bag/FindContactFieldOptionsBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindContactFieldOptionsBag
 {
 
diff --git a/src/Feature/Contacts/Fields/Bag/UpdateContactFieldBag.php b/src/Feature/Contacts/Fields/Bag/UpdateContactFieldBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class UpdateContactFieldBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/AssignContactToGroupBag.php b/src/Feature/Contacts/Groups/Bag/AssignContactToGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class AssignContactToGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/CreateGroupBag.php b/src/Feature/Contacts/Groups/Bag/CreateGroupBag.php
@@ -10,6 +10,7 @@
  * @property string $idx
  * @property integer $contactExpireAfter
  */
+#[\AllowDynamicProperties]
 class CreateGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/DeleteGroupBag.php b/src/Feature/Contacts/Groups/Bag/DeleteGroupBag.php
@@ -8,6 +8,7 @@
  * @api
  * @property bool $deleteContacts
  */
+#[\AllowDynamicProperties]
 class DeleteGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/FindContactGroupBag.php b/src/Feature/Contacts/Groups/Bag/FindContactGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindContactGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/FindContactGroupsBag.php b/src/Feature/Contacts/Groups/Bag/FindContactGroupsBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindContactGroupsBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/FindGroupBag.php b/src/Feature/Contacts/Groups/Bag/FindGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/UnpinContactFromGroupBag.php b/src/Feature/Contacts/Groups/Bag/UnpinContactFromGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class UnpinContactFromGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Bag/UpdateGroupBag.php b/src/Feature/Contacts/Groups/Bag/UpdateGroupBag.php
@@ -10,6 +10,7 @@
  * @property string $idx
  * @property integer $contactExpireAfter
  */
+#[\AllowDynamicProperties]
 class UpdateGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/AddContactToGroupByQueryBag.php b/src/Feature/Contacts/Groups/Members/Bag/AddContactToGroupByQueryBag.php
@@ -15,6 +15,7 @@
  * @property string $gender
  * @property string $birthdayDate
  */
+#[\AllowDynamicProperties]
 class AddContactToGroupByQueryBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/FindContactInGroupBag.php b/src/Feature/Contacts/Groups/Members/Bag/FindContactInGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindContactInGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/MoveContactToGroupByQueryBag.php b/src/Feature/Contacts/Groups/Members/Bag/MoveContactToGroupByQueryBag.php
@@ -15,6 +15,7 @@
  * @property string $gender
  * @property string $birthdayDate
  */
+#[\AllowDynamicProperties]
 class MoveContactToGroupByQueryBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/PinContactToGroupBag.php b/src/Feature/Contacts/Groups/Members/Bag/PinContactToGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class PinContactToGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/UnpinContactFromGroupBag.php b/src/Feature/Contacts/Groups/Members/Bag/UnpinContactFromGroupBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class UnpinContactFromGroupBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Members/Bag/UnpinContactFromGroupByQueryBag.php b/src/Feature/Contacts/Groups/Members/Bag/UnpinContactFromGroupByQueryBag.php
@@ -15,6 +15,7 @@
  * @property string $gender
  * @property string $birthdayDate
  */
+#[\AllowDynamicProperties]
 class UnpinContactFromGroupByQueryBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Permissions/Bag/CreateGroupPermissionBag.php b/src/Feature/Contacts/Groups/Permissions/Bag/CreateGroupPermissionBag.php
@@ -10,6 +10,7 @@
  * @property string $write
  * @property string $send
  */
+#[\AllowDynamicProperties]
 class CreateGroupPermissionBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Permissions/Bag/DeleteGroupPermissionBag.php b/src/Feature/Contacts/Groups/Permissions/Bag/DeleteGroupPermissionBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class DeleteGroupPermissionBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Permissions/Bag/FindGroupPermissionBag.php b/src/Feature/Contacts/Groups/Permissions/Bag/FindGroupPermissionBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindGroupPermissionBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Permissions/Bag/FindGroupPermissionsBag.php b/src/Feature/Contacts/Groups/Permissions/Bag/FindGroupPermissionsBag.php
@@ -7,6 +7,7 @@
 /**
  * @api
  */
+#[\AllowDynamicProperties]
 class FindGroupPermissionsBag
 {
 
diff --git a/src/Feature/Contacts/Groups/Permissions/Bag/UpdateGroupPermissionBag.php b/src/Feature/Contacts/Groups/Permissions/Bag/UpdateGroupPermissionBag.php
@@ -10,6 +10,7 @@
  * @property string $write
  * @property string $send
  */
+#[\AllowDynamicProperties]
 class UpdateGroupPermissionBag
 {
 
diff --git a/src/Feature/Hlr/Bag/SendHlrBag.php b/src/Feature/Hlr/Bag/SendHlrBag.php
@@ -8,6 +8,7 @@
  * @api
  * @property string $idx
  */
+#[\AllowDynamicProperties]
 class SendHlrBag
 {
 
diff --git a/src/Feature/Mfa/Bag/CreateMfaBag.php b/src/Feature/Mfa/Bag/CreateMfaBag.php
diff --git a/src/Feature/Mfa/Bag/VerificationMfaBag.php b/src/Feature/Mfa/Bag/VerificationMfaBag.php
diff --git a/src/Feature/Mms/Bag/SendMmsBag.php b/src/Feature/Mms/Bag/SendMmsBag.php
diff --git a/src/Feature/ShortUrl/Bag/CreateShortUrlLinkBag.php b/src/Feature/ShortUrl/Bag/CreateShortUrlLinkBag.php
diff --git a/src/Feature/Sms/Bag/DeleteScheduledSmssBag.php b/src/Feature/Sms/Bag/DeleteScheduledSmssBag.php
diff --git a/src/Feature/Sms/Bag/ScheduleSmsBag.php b/src/Feature/Sms/Bag/ScheduleSmsBag.php
diff --git a/src/Feature/Sms/Bag/ScheduleSmsToGroupBag.php b/src/Feature/Sms/Bag/ScheduleSmsToGroupBag.php
diff --git a/src/Feature/Sms/Bag/ScheduleSmssBag.php b/src/Feature/Sms/Bag/ScheduleSmssBag.php
diff --git a/src/Feature/Sms/Bag/SendSmsBag.php b/src/Feature/Sms/Bag/SendSmsBag.php
diff --git a/src/Feature/Sms/Bag/SendSmsToGroupBag.php b/src/Feature/Sms/Bag/SendSmsToGroupBag.php
diff --git a/src/Feature/Sms/Bag/SendSmssBag.php b/src/Feature/Sms/Bag/SendSmssBag.php
diff --git a/src/Feature/Sms/Sendernames/Bag/CreateSendernameBag.php b/src/Feature/Sms/Sendernames/Bag/CreateSendernameBag.php
diff --git a/src/Feature/Sms/Sendernames/Bag/DeleteSendernameBag.php b/src/Feature/Sms/Sendernames/Bag/DeleteSendernameBag.php
diff --git a/src/Feature/Sms/Sendernames/Bag/FindSendernameBag.php b/src/Feature/Sms/Sendernames/Bag/FindSendernameBag.php
diff --git a/src/Feature/Sms/Sendernames/Bag/MakeSendernameDefaultBag.php b/src/Feature/Sms/Sendernames/Bag/MakeSendernameDefaultBag.php
diff --git a/src/Feature/Subusers/Bag/CreateSubuserBag.php b/src/Feature/Subusers/Bag/CreateSubuserBag.php
diff --git a/src/Feature/Subusers/Bag/DeleteSubuserBag.php b/src/Feature/Subusers/Bag/DeleteSubuserBag.php
diff --git a/src/Feature/Subusers/Bag/UpdateSubuserBag.php b/src/Feature/Subusers/Bag/UpdateSubuserBag.php
diff --git a/src/Feature/Vms/Bag/SendVmsBag.php b/src/Feature/Vms/Bag/SendVmsBag.php

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`}`
`17`	`17`	`},`
`18`	`18`	`"require": {`
`19`		`- "php": "^7 \|\| ~8.0 \|\| ~8.1",`
	`19`	`+ "php": "^7 \|\| ~8.0 \|\| ~8.1 \|\| ~8.2",`
`20`	`20`	`"ext-json": "*",`
`21`	`21`	`"psr/log": "^1 \|\| ^2 \|\| ^3",`
`22`	`22`	`"psr/http-message": "^1",`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`* @api`
`11`	`11`	`* @property DateTimeInterface $expireAt`
`12`	`12`	`*/`
	`13`	`+#[\AllowDynamicProperties]`
`13`	`14`	`class CreateBlacklistedPhoneNumberBag`
`14`	`15`	`{`
`15`	`16`	`/** @var string */`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`/**`
`8`	`8`	`* @api`
`9`	`9`	`*/`
	`10`	`+#[\AllowDynamicProperties]`
`10`	`11`	`class DeleteBlacklistedPhoneNumberBag`
`11`	`12`	`{`
`12`	`13`	`/** @var string */`