Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number identified as a date #676

Open
joffreyvillard opened this issue Oct 12, 2018 · 1 comment
Open

Number identified as a date #676

joffreyvillard opened this issue Oct 12, 2018 · 1 comment

Comments

@joffreyvillard
Copy link

Hi,
First, thanks for releasing the whole library here on Github! :)

I experienced the following unexpected behavior: when asking "and between 1k and 2k", the first number "1k" is well identified as a number with value 1000, but the second one "2k" is identified as a date (year "2000").
Detailed response is provided below.

I understand that I may improve my training sentences to include more such cases, but anyway "2k" can't be a date IMO.

Best,
Joffrey

Details

{
  "input": "and between 1k and 2k",
  "intent": {
    "intentName": "update_entities",
    "probability": 0.8765742904755668
  },
  "slots": [
    {
      "entity": "segment",
      "range": {
        "end": 11,
        "start": 4
      },
      "rawValue": "between",
      "slotName": "segment",
      "value": {
        "kind": "Custom",
        "value": "between"
      }
    },
    {
      "entity": "snips/number",
      "range": {
        "end": 14,
        "start": 12
      },
      "rawValue": "1k",
      "slotName": "number",
      "value": {
        "kind": "Number",
        "value": 1000.0
      }
    },
    {
      "entity": "snips/datetime",
      "range": {
        "end": 21,
        "start": 19
      },
      "rawValue": "2k",
      "slotName": "date-time",
      "value": {
        "grain": "Year",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2000-01-01 00:00:00 +01:00"
      }
    }
  ]
}
@adrienball
Copy link
Contributor

Hey @joffreyvillard ,
Thanks for the feedback, it is indeed a bug. We'll have a look at it and will keep you updated here.

Best,
Adrien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants