From 653f7168cfcb40d8b40a0c0f2d12a5859cee6783 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filip=20Paw=C5=82owski?= Date: Fri, 5 Sep 2025 13:51:06 +0200 Subject: [PATCH] NO-SNOW: no more tests assertion details --- test/integ/test_large_result_set.py | 14 +++++++++----- test/integ/test_put_get_with_azure_token.py | 14 +++++++++----- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/test/integ/test_large_result_set.py b/test/integ/test_large_result_set.py index e88f6a70a4..3588ab4d6f 100644 --- a/test/integ/test_large_result_set.py +++ b/test/integ/test_large_result_set.py @@ -168,11 +168,15 @@ def test_query_large_result_set(conn_cnx, db_parameters, ingest_data, caplog): if expected_token_prefix in line: aws_request_present = True # getattr is used to stay compatible with old driver - before SECRET_STARRED_MASK_STR was added - assert ( - expected_token_prefix - + getattr(SecretDetector, "SECRET_STARRED_MASK_STR", "****") - in line - ), "connectionpool logger is leaking sensitive information" + masked_signature = expected_token_prefix + getattr( + SecretDetector, "SECRET_STARRED_MASK_STR", "****" + ) + if masked_signature not in line: + # Use SecretDetector to mask the line before showing it in error + _, masked_line, _ = SecretDetector.mask_secrets(line) + raise AssertionError( + f"connectionpool logger is leaking sensitive information. Masked line: {masked_line}" + ) assert ( aws_request_present diff --git a/test/integ/test_put_get_with_azure_token.py b/test/integ/test_put_get_with_azure_token.py index 7e2e011c72..21d9465203 100644 --- a/test/integ/test_put_get_with_azure_token.py +++ b/test/integ/test_put_get_with_azure_token.py @@ -89,11 +89,15 @@ def test_put_get_with_azure(tmpdir, conn_cnx, from_path, caplog): if "blob.core.windows.net" in line and expected_token_prefix in line: azure_request_present = True # getattr is used to stay compatible with old driver - before SECRET_STARRED_MASK_STR was added - assert ( - expected_token_prefix - + getattr(SecretDetector, "SECRET_STARRED_MASK_STR", "****") - in line - ), "connectionpool logger is leaking sensitive information" + masked_signature = expected_token_prefix + getattr( + SecretDetector, "SECRET_STARRED_MASK_STR", "****" + ) + if masked_signature not in line: + # Use SecretDetector to mask the line before showing it in error + _, masked_line, _ = SecretDetector.mask_secrets(line) + raise AssertionError( + f"connectionpool logger is leaking sensitive information. Masked line: {masked_line}" + ) assert ( azure_request_present