Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasses building under WSL #241

Open
3 tasks
mribbons opened this issue Mar 15, 2023 · 4 comments
Open
3 tasks

Reasses building under WSL #241

mribbons opened this issue Mar 15, 2023 · 4 comments
Assignees

Comments

@mribbons
Copy link
Contributor

manual libuv build is now possible, we just need to extract the necessary options from libuv's generated .vsproj and pass those th clang.

I can't recall if there were other blockers.

  • Test MSVC clang/++ from WSL
  • Test ssc build with prebuilt libuv
  • Test android builds
@jwerle
Copy link
Member

jwerle commented Mar 15, 2023

IIRC, I believe you can run software compiled for Windows in WSL, but you cannot run software compiled in WSL for Windows. We'll need to cross compile for Windows in WSL

@mribbons
Copy link
Contributor Author

We'll need to cross compile for Windows in WSL

It looks like that project is still using MSVC and Windows SDK, that's what I had in mind :)

@mribbons
Copy link
Contributor Author

mribbons commented Mar 22, 2023

This came up after building from a WSL path mapped to a network drive. The same will occur within WSL:

U:/home/test/socket/build/include\WebView2ExperimentalEnvironmentOptions.h:12:10: fatal error:
      'webview2experimental.h' file not found
#include "webview2experimental.h"

hack:

cp build/include/WebView2.h build/include/webview2.h
cp build/include/WebView2Experimental.h build/include/webview2experimental.h

To resolve we would need to request MS to fix the headers, or patch them after extracting.

@mribbons
Copy link
Contributor Author

mribbons commented Mar 22, 2023

Running install.ps1 from powershell in WSL folder and VS build tools installed:"

PS Microsoft.PowerShell.Core\FileSystem::\\wsl.localhost\Ubuntu-20.04\home\user\socket> Set-ExecutionPolicy Bypass
# ... /y
PS Microsoft.PowerShell.Core\FileSystem::\\wsl.localhost\Ubuntu-20.04\home\user\socket> .\bin\install.ps1 -verbose
# Using toolchain: vsbuild
# C:\WINDOWS\System32\vcruntime140_1.dll found.
# Git found at, changing path to: git.exe
# Found git.exe
# Calling vcvars64.bat
'\\wsl.localhost\Ubuntu-20.04\home\user\socket'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
# C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat didn't enable both clang++ and nmake, downloading vs_build.exe
clang 15.0.0, Windows SDK and nmake are required, proceed with install from Microsoft? y/[n]?
>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants