Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging warnings or errors on unit tests #1319

Open
baturayo opened this issue May 4, 2022 · 1 comment
Open

Allow logging warnings or errors on unit tests #1319

baturayo opened this issue May 4, 2022 · 1 comment

Comments

@baturayo
Copy link
Contributor

baturayo commented May 4, 2022

Unit tests using tests.helpers.scanner.Scanner object fails by default if there is a warning or error in the logs. It is due to the assert_no_error_nor_warning_logs method.

For some unit tests, we need to have warnings. For example, automated monitoring test raises a warning message that "Automated monitoring is not implemented yet!.." but due to this message the unit test fails.

By default, we can raise an AssertionError if there is an error or warning log but for some exceptional cases like automated monitoring, we can have an argument in the tests.helpers.scanner.Scanner class that does not fail in case of warnings or errors.

CC: @bastienboutonnet @tombaeyens @vijaykiran

@jmarien
Copy link
Contributor

jmarien commented May 4, 2022

SODA-262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants