Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change percent logic is a failure condition, which is reverse from the norm #1547

Open
guxie opened this issue Aug 16, 2022 · 1 comment
Open

Comments

@guxie
Copy link

guxie commented Aug 16, 2022

- change percent for row_count > 50%
The condition above is meant to fail anything that is NOT above the 50% threshold.
All other checks are designed to indicate the success condition, where this is a definition of a failure condition.

I'd recommend updating it such that the above change percent check is specifically as a success condition, which is the norm in other checks.

@janet-can
Copy link
Contributor

I agree, the thread we were troubleshooting on offers a little more context, but both of us had to stop and think and test to validate the logic to really understand it. Would be good to have a completely consistent paradigm of setting pass state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants