Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Error Message for Whitespace Issues #1623

Open
jackdesert opened this issue Oct 4, 2022 · 1 comment
Open

Clear Error Message for Whitespace Issues #1623

jackdesert opened this issue Oct 4, 2022 · 1 comment

Comments

@jackdesert
Copy link

Perhaps there could be a clear error message for whitespace issues.

For example, this checks file works:

checks for agr_one_file:
    - custom_test_count = 8000000:
        custom_test_count query:  SELECT max(zip) FROM agr_one_file

But this checks file (the same except the last line has two less leading spaces) generates an error.

checks for agr_one_file:
    - custom_test_count = 8000000:
      custom_test_count query:  SELECT max(zip) FROM agr_one_file

Here is the error that is generated using the latter file:

(soda) @ws soda-core-example soda scan -d source_one -c configuration.yml checks-two-spaces.yml
Soda Core 3.0.5
Could not add SodaCL file checks-two-spaces.yml
  | 'NoneType' object is not iterable
Scan summary:
No checks found, 0 checks evaluated.
1 errors.
Oops! 1 error. 0 failures. 0 warnings. 0 pass.
ERRORS:
Could not add SodaCL file checks-two-spaces.yml
  | 'NoneType' object is not iterable

It took us a while to determine it was a whitespace issue.

@jmarien
Copy link
Contributor

jmarien commented Oct 4, 2022

SODA-1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants