Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hover::starknet tests #312

Closed
mkaput opened this issue Feb 17, 2025 · 0 comments · Fixed by #345
Closed

Replace hover::starknet tests #312

mkaput opened this issue Feb 17, 2025 · 0 comments · Fixed by #345
Assignees

Comments

@mkaput
Copy link
Member

mkaput commented Feb 17, 2025

The hover::starknet family of tests is pretty coarse grained which is neither helpful when it fails, nor it finds precise bugs in our code.

  1. Find out what precise code paths of our codebase these tests are testing.
  2. Reduce these down to something that is not relying on starknet plugin.
  3. Remove hover::starknet tests altogether

Hint: I think all plugin-related stuff in this tests reduces down to #[generate_trait] which is compiler builtin

@mkaput mkaput moved this to Triage in Cairo Language Services Feb 17, 2025
@mkaput mkaput moved this from Triage to Backlog in Cairo Language Services Feb 17, 2025
@Draggu Draggu self-assigned this Feb 20, 2025
@Draggu Draggu moved this from Backlog to In Progress in Cairo Language Services Feb 20, 2025
Draggu added a commit that referenced this issue Feb 21, 2025
Close #312

commit-id:c33d9542
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cairo Language Services Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants