Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saltman: Speeding things up #40

Open
mycarta opened this issue Sep 27, 2019 · 2 comments
Open

Saltman: Speeding things up #40

mycarta opened this issue Sep 27, 2019 · 2 comments
Assignees
Labels

Comments

@mycarta
Copy link
Member

mycarta commented Sep 27, 2019

First a general comment: I really like this chapter, content and style. Exactly the kind of reading I wish I'd done on week 1, say day 2 of my Python adventure. It will help many.

The code works. I run all of it and got the same results.

Text without the code snippet is ~650 words, just about right.

But it is double that amount with the code; I am not sure if it'll fit, I'd check with @kwinkunks - I wonder if you could aggregate all code into a figure with 4 subplots (a, b, c, d) and use screen captures of the snippets instead of text. Just a thought.

@mycarta mycarta self-assigned this Sep 27, 2019
@mycarta mycarta added the review label Sep 27, 2019
@epsalt
Copy link
Contributor

epsalt commented Sep 27, 2019

Thanks for the review Matteo, I really appreciate it. If the chapter is too long I could always split it in two. There is a natural break halfway through the chapter.

@mycarta
Copy link
Member Author

mycarta commented Oct 2, 2019

I think @kwinkunks is in a better position to comment about length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants