From 1c3dab64fe0190a07e8716f2e3ffe4ec9e8e9b24 Mon Sep 17 00:00:00 2001 From: tobySolutions Date: Tue, 4 Aug 2026 14:42:11 +0100 Subject: [PATCH 1/2] fix(web): stop the active filter count vanishing into its own badge --- .../payments/transactions/transactions-workspace.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx b/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx index e28c512f4..9c607e3ba 100644 --- a/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx +++ b/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx @@ -590,7 +590,12 @@ export function TransactionsWorkspace({ > {t("DashboardPayments.transactions.filters")} {advancedFilterCount > 0 ? ( - + // `text-white` against `bg-primary` is invisible in dark mode: + // primary resolves near-white there, so the count vanished into + // its own pill. `on-primary` is the paired token and flips with + // the theme. Sized as a circle rather than padded, so a single + // digit is not an oval. + {advancedFilterCount} ) : null} From 5f601dc582aa81491a284f62ca8875270962741b Mon Sep 17 00:00:00 2001 From: tobySolutions Date: Tue, 4 Aug 2026 14:52:56 +0100 Subject: [PATCH 2/2] fix(web): stop the filter count appearing twice on the transactions toolbar --- .../transactions/transactions-workspace.tsx | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx b/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx index 9c607e3ba..6c65e4079 100644 --- a/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx +++ b/apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx @@ -588,17 +588,11 @@ export function TransactionsWorkspace({ aria-controls="payments-transaction-advanced-filters" onClick={() => setFiltersOpen((open) => !open)} > + {/* No count badge here: "N active" renders directly below on the + same condition, so the badge repeated it in a less useful form — + a bare number, crowded against the button edge, next to a line + that says what the number actually means and offers to clear it. */} {t("DashboardPayments.transactions.filters")} - {advancedFilterCount > 0 ? ( - // `text-white` against `bg-primary` is invisible in dark mode: - // primary resolves near-white there, so the count vanished into - // its own pill. `on-primary` is the paired token and flips with - // the theme. Sized as a circle rather than padded, so a single - // digit is not an oval. - - {advancedFilterCount} - - ) : null}