You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, we inadvertently removed some Gloo EE API protos in the process.
For example:
proxylatency is a Gloo API proto (it's an enterprise feature) that we do need the API ref doc for. But because its package is envoy.config.filter.http.proxylatency.v2, it is removed because it looks like one of the envoy external protos.
I also think transformation with the package envoy.config.filter.http.transformation_ee.v2 looks like it needs to be built, just based on the ee in the package name
Link to any relevant existing docs
No response
Browser Information
No response
Additional Context
Seth mentioned that "we could have a regex like "github.com/solo-io/gloo/projects/gloo/api/external/[^envoy]" (although that is not the correct syntax and I think go's regexes might be limited in the use of look aheads that are needed to do negative string matching. Passing a filter function might be a cleaner approach."
The text was updated successfully, but these errors were encountered:
Version
main (1.18.x beta)
Gateway API
Gloo Edge API
Describe the requested changes
@sheidkamp developed some logic in https://github.com/solo-io/gloo/pull/10065/files#diff-daddc66424f674dc57b411e63fce1f1bd231a27a77e39d25c781b4a8ca6f6062 to block external API protos from being built into API refenence docs. This decluttered our API reference so that only our Gloo API docs were published, instead of publishing, for example, every envoy proto that we pull in.
However, we inadvertently removed some Gloo EE API protos in the process.
For example:
envoy.config.filter.http.proxylatency.v2
, it is removed because it looks like one of the envoy external protos.envoy.config.filter.http.transformation_ee.v2
looks like it needs to be built, just based on theee
in the package nameLink to any relevant existing docs
No response
Browser Information
No response
Additional Context
Seth mentioned that "we could have a regex like "github.com/solo-io/gloo/projects/gloo/api/external/[^envoy]" (although that is not the correct syntax and I think go's regexes might be limited in the use of look aheads that are needed to do negative string matching. Passing a filter function might be a cleaner approach."
The text was updated successfully, but these errors were encountered: