You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When playing around with protoc-gen-ext v0.0.16 and using option (extproto.clone_all) = true;, I've noticed an inconsitency from the generated object.Clone() methods vs. the previously-used proto.Clone(object) method. Specifically:
The nested field of UpstreamSpec.Selector changed how it is cloned in the default case. Where previously no provided value --> clone would equate to nil, now a clone generates an empty map: map[string]string{}.
While not a breaking (or important) change at the moment, I'm documenting this, as there may be (as of now) unforeseen consequences to changing default map values on clone.
When playing around with
protoc-gen-ext v0.0.16
and usingoption (extproto.clone_all) = true;
, I've noticed an inconsitency from the generatedobject.Clone()
methods vs. the previously-usedproto.Clone(object)
method. Specifically:The nested field of
UpstreamSpec.Selector
changed how it is cloned in the default case. Where previously no provided value --> clone would equate tonil
, now a clone generates an empty map:map[string]string{}
.While not a breaking (or important) change at the moment, I'm documenting this, as there may be (as of now) unforeseen consequences to changing default
map
values on clone.Further (potentially better-written) context by @sam-heilbron: solo-io/gloo#5658 (comment)
The text was updated successfully, but these errors were encountered: