Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add CLI support for configuring persistent drop monitor #3757

Open
arista-hpandya opened this issue Feb 7, 2025 · 0 comments · May be fixed by #3756
Open

[Feature] Add CLI support for configuring persistent drop monitor #3757

arista-hpandya opened this issue Feb 7, 2025 · 0 comments · May be fixed by #3756

Comments

@arista-hpandya
Copy link
Contributor

Description:

This issue tracks the implementation of CLI support for configuring and managing the persistent drop monitor feature in SONiC. This feature enables users to define thresholds for drop counts and incident counts within a specified time window, which triggers syslog entries when persistent drops are detected.

Tasks:

  • Implement new CLI commands to enable/disable and configure the persistent drop monitor, including:
    • Setting the monitoring window size (-w/--window)
    • Setting the drop count threshold (-dct/--drop-count-threshold)
    • Setting the incident count threshold (-ict/--incident-count-threshold)
  • Update the show dropcounters monitor command to display the current monitor configuration.
  • Implement input validation and error handling for the new CLI commands.
  • Add unit tests to cover the new CLI functionality.
  • Update documentation to reflect the new CLI commands and options.

Background:

The persistent drop monitor feature allows for proactive monitoring and identification of persistent packet drops in the SONiC environment. It builds upon the existing drop counter functionality and provides a mechanism to detect and log sustained drop patterns. The configuration is global and applies to all configured drop counters on the device.

References:

Assignee:
@arista-hpandya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant