Skip to content

Commit b61cdf6

Browse files
committed
Renamed otp to sms
1 parent b4ee2db commit b61cdf6

16 files changed

+63
-66
lines changed

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,10 @@ public class MessageListener {
117117
log.info("Notification message: {}", notification);
118118
}
119119

120-
// asynchronously send otp to the user
121-
@RqueueListener(value = "otp", priority="critical=10,high=8,medium=4,low=1")
122-
public void onMessage(Otp otp) {
123-
log.info("Otp message: {}", otp);
120+
// asynchronously send sms to the user
121+
@RqueueListener(value = "sms", priority="critical=10,high=8,medium=4,low=1")
122+
public void onMessage(Sms sms) {
123+
log.info("Sms message: {}", sms);
124124
}
125125
}
126126
```

rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/MessageListener.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import com.github.sonus21.rqueue.test.dto.FeedGeneration;
2323
import com.github.sonus21.rqueue.test.dto.Job;
2424
import com.github.sonus21.rqueue.test.dto.Notification;
25-
import com.github.sonus21.rqueue.test.dto.Otp;
25+
import com.github.sonus21.rqueue.test.dto.Sms;
2626
import com.github.sonus21.rqueue.test.dto.Reservation;
2727
import com.github.sonus21.rqueue.test.service.ConsumedMessageService;
2828
import com.github.sonus21.rqueue.test.service.FailureManager;
@@ -77,17 +77,17 @@ public void onMessage(Email email) throws Exception {
7777
}
7878

7979
@RqueueListener(
80-
value = "${otp.queue}",
81-
active = "${otp.queue.active}",
82-
priority = "${otp.queue.priority}",
83-
priorityGroup = "${otp.queue.group}",
84-
concurrency = "${otp.queue.concurrency}")
85-
public void onMessage(Otp otp) throws Exception {
86-
log.info("OtpListener: {}", otp);
87-
if (failureManager.shouldFail(otp.getId())) {
88-
throw new Exception("Failing otp task to be retried" + otp);
80+
value = "${sms.queue}",
81+
active = "${sms.queue.active}",
82+
priority = "${sms.queue.priority}",
83+
priorityGroup = "${sms.queue.group}",
84+
concurrency = "${sms.queue.concurrency}")
85+
public void onMessage(Sms sms) throws Exception {
86+
log.info("SmsListener: {}", sms);
87+
if (failureManager.shouldFail(sms.getId())) {
88+
throw new Exception("Failing sms task to be retried" + sms);
8989
}
90-
consumedMessageService.save(otp);
90+
consumedMessageService.save(sms);
9191
}
9292

9393
@RqueueListener(

rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/dto/Otp.java rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/dto/Sms.java

+7-10
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.github.sonus21.rqueue.test.dto;
1818

19-
import java.util.Random;
2019
import java.util.UUID;
2120
import lombok.AllArgsConstructor;
2221
import lombok.EqualsAndHashCode;
@@ -32,16 +31,14 @@
3231
@Setter
3332
@ToString
3433
@EqualsAndHashCode(callSuper = true)
35-
public class Otp extends BaseQueueMessage {
34+
public class Sms extends BaseQueueMessage {
3635
private String phoneNumber;
37-
private String otp;
36+
private String sms;
3837

39-
public static Otp newInstance() {
40-
Otp otp =
41-
new Otp(
42-
"+91" + RandomStringUtils.randomNumeric(10),
43-
String.valueOf(new Random().nextInt(100000)));
44-
otp.setId(UUID.randomUUID().toString());
45-
return otp;
38+
public static Sms newInstance() {
39+
String txt = "Dear , Version 2.0 of Rqueue is released.";
40+
Sms sms = new Sms("+91" + RandomStringUtils.randomNumeric(10), txt);
41+
sms.setId(UUID.randomUUID().toString());
42+
return sms;
4643
}
4744
}

rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/tests/AllQueueMode.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.github.sonus21.rqueue.test.dto.Email;
2222
import com.github.sonus21.rqueue.test.dto.FeedGeneration;
2323
import com.github.sonus21.rqueue.test.dto.Job;
24-
import com.github.sonus21.rqueue.test.dto.Otp;
24+
import com.github.sonus21.rqueue.test.dto.Sms;
2525
import com.github.sonus21.rqueue.test.dto.Reservation;
2626
import com.github.sonus21.rqueue.utils.Constants;
2727
import com.github.sonus21.rqueue.utils.TimeoutUtils;
@@ -41,20 +41,20 @@ protected void checkGroupConsumer() throws TimedOutException {
4141
}
4242

4343
protected void checkQueueLevelConsumer() throws TimedOutException {
44-
rqueueMessageSender.enqueue(otpQueue, Otp.newInstance());
45-
rqueueMessageSender.enqueueWithPriority(otpQueue, "critical", Otp.newInstance());
46-
rqueueMessageSender.enqueueWithPriority(otpQueue, "high", Otp.newInstance());
47-
rqueueMessageSender.enqueueWithPriority(otpQueue, "medium", Otp.newInstance());
48-
rqueueMessageSender.enqueueWithPriority(otpQueue, "low", Otp.newInstance());
44+
rqueueMessageSender.enqueue(smsQueue, Sms.newInstance());
45+
rqueueMessageSender.enqueueWithPriority(smsQueue, "critical", Sms.newInstance());
46+
rqueueMessageSender.enqueueWithPriority(smsQueue, "high", Sms.newInstance());
47+
rqueueMessageSender.enqueueWithPriority(smsQueue, "medium", Sms.newInstance());
48+
rqueueMessageSender.enqueueWithPriority(smsQueue, "low", Sms.newInstance());
4949
TimeoutUtils.waitFor(
5050
() ->
5151
getMessageCount(
5252
Arrays.asList(
53-
otpQueue,
54-
otpQueue + "_critical",
55-
otpQueue + "_high",
56-
otpQueue + "_medium",
57-
otpQueue + "_low"))
53+
smsQueue,
54+
smsQueue + "_critical",
55+
smsQueue + "_high",
56+
smsQueue + "_medium",
57+
smsQueue + "_low"))
5858
== 0,
5959
20 * Constants.ONE_MILLI,
6060
"multi level queues to drain");

rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/tests/MultiLevelQueueListenerTestBase.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@
1717
package com.github.sonus21.rqueue.test.tests;
1818

1919
import com.github.sonus21.rqueue.exception.TimedOutException;
20-
import com.github.sonus21.rqueue.test.dto.Otp;
20+
import com.github.sonus21.rqueue.test.dto.Sms;
2121
import com.github.sonus21.rqueue.utils.TimeoutUtils;
2222
import java.util.Arrays;
2323

2424
public abstract class MultiLevelQueueListenerTestBase extends SpringTestBase {
2525
protected void checkQueueLevelConsumer() throws TimedOutException {
26-
rqueueMessageSender.enqueue(otpQueue, Otp.newInstance());
27-
rqueueMessageSender.enqueueWithPriority(otpQueue, "critical", Otp.newInstance());
28-
rqueueMessageSender.enqueueWithPriority(otpQueue, "high", Otp.newInstance());
29-
rqueueMessageSender.enqueueWithPriority(otpQueue, "medium", Otp.newInstance());
30-
rqueueMessageSender.enqueueWithPriority(otpQueue, "low", Otp.newInstance());
26+
rqueueMessageSender.enqueue(smsQueue, Sms.newInstance());
27+
rqueueMessageSender.enqueueWithPriority(smsQueue, "critical", Sms.newInstance());
28+
rqueueMessageSender.enqueueWithPriority(smsQueue, "high", Sms.newInstance());
29+
rqueueMessageSender.enqueueWithPriority(smsQueue, "medium", Sms.newInstance());
30+
rqueueMessageSender.enqueueWithPriority(smsQueue, "low", Sms.newInstance());
3131
TimeoutUtils.waitFor(
3232
() ->
3333
getMessageCount(
3434
Arrays.asList(
35-
otpQueue,
36-
otpQueue + "_critical",
37-
otpQueue + "_high",
38-
otpQueue + "_medium",
39-
otpQueue + "_low"))
35+
smsQueue,
36+
smsQueue + "_critical",
37+
smsQueue + "_high",
38+
smsQueue + "_medium",
39+
smsQueue + "_low"))
4040
== 0,
4141
"Waiting for multi level queues to drain");
4242
}

rqueue-common-test/src/main/java/com/github/sonus21/rqueue/test/tests/SpringTestBase.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ public abstract class SpringTestBase {
6767
@Value("${notification.queue.retry.count}")
6868
protected int notificationRetryCount;
6969

70-
@Value("${otp.queue}")
71-
protected String otpQueue;
70+
@Value("${sms.queue}")
71+
protected String smsQueue;
7272

7373
@Value("${feed.generation.queue}")
7474
protected String feedGenerationQueue;

rqueue-common-test/src/main/resources/application.properties

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ email.queue.active=true
1313
mysql.db.name=test
1414
rqueue.metrics.tags.rqueue=test
1515
email.execution.time=15*60*1000
16-
otp.queue=otp
17-
otp.queue.active=false
18-
otp.queue.group=
19-
otp.queue.priority=critical:10, high:6, medium:4, low:2
20-
otp.queue.concurrency=-1
16+
sms.queue=sms
17+
sms.queue.active=false
18+
sms.queue.group=
19+
sms.queue.priority=critical:10, high:6, medium:4, low:2
20+
sms.queue.concurrency=-1
2121
chat.indexing.queue=chat-indexing
2222
chat.indexing.queue.active=false
2323
chat.indexing.queue.priority=30

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/SpringAppTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
properties = {
4848
"spring.redis.port=7004",
4949
"mysql.db.name=SpringAppTest",
50-
"otp.queue.active=true",
50+
"sms.queue.active=true",
5151
"notification.queue.active=false",
5252
"email.queue.active=true",
5353
"job.queue.active=true",
@@ -71,7 +71,7 @@ public void numActiveQueues() {
7171
assertTrue(registeredQueue.containsKey(jobQueue));
7272
assertTrue(registeredQueue.containsKey(feedGenerationQueue));
7373
assertTrue(registeredQueue.containsKey(reservationQueue));
74-
assertTrue(registeredQueue.containsKey(otpQueue));
74+
assertTrue(registeredQueue.containsKey(smsQueue));
7575
}
7676

7777
@Test

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/StrictHeterogeneousConcurrencyBasedQueueListener.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@
3535
properties = {
3636
"spring.redis.port=7013",
3737
"mysql.db.name=StrictHeterogeneousConcurrencyBasedQueueListener",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=true",
4141
"job.queue.active=true",
4242
"priority.mode=STRICT",
4343
"reservation.queue.active=true",
4444
"feed.generation.queue.active=true",
4545
"chat.indexing.queue.active=true",
46-
"otp.queue.concurrency=5",
46+
"sms.queue.concurrency=5",
4747
"reservation.queue.concurrency=2",
4848
"feed.generation.queue.concurrency=1-5",
4949
"chat.indexing.queue.concurrency=3-5",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/StrictHeterogeneousQueueListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
properties = {
3636
"spring.redis.port=7011",
3737
"mysql.db.name=StrictHeterogeneousQueueListener",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=true",
4141
"job.queue.active=true",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/StrictMultiLevelQueueListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"spring.redis.port=7007",
3737
"mysql.db.name=StrictMultiLevelQueueListener",
3838
"max.workers.count=10",
39-
"otp.queue.active=true",
39+
"sms.queue.active=true",
4040
"notification.queue.active=false",
4141
"email.queue.active=false",
4242
"job.queue.active=false",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/StrictPriorityQueueListenerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
properties = {
3636
"spring.redis.port=7009",
3737
"mysql.db.name=StrictPriorityQueueListenerTest",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=false",
4141
"job.queue.active=false",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/WeightedHeterogeneousConcurrencyBasedQueueListener.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@
3535
properties = {
3636
"spring.redis.port=7014",
3737
"mysql.db.name=WeightedHeterogeneousConcurrencyBasedQueueListener",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=true",
4141
"job.queue.active=true",
4242
"priority.mode=WEIGHTED",
4343
"reservation.queue.active=true",
4444
"feed.generation.queue.active=true",
4545
"chat.indexing.queue.active=true",
46-
"otp.queue.concurrency=5",
46+
"sms.queue.concurrency=5",
4747
"reservation.queue.concurrency=2",
4848
"feed.generation.queue.concurrency=1-5",
4949
"chat.indexing.queue.concurrency=3-5"

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/WeightedHeterogeneousQueueListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
properties = {
3636
"spring.redis.port=7012",
3737
"mysql.db.name=WeightedHeterogeneousQueueListener",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=true",
4141
"job.queue.active=true",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/WeightedMultiLevelQueueListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
properties = {
3636
"spring.redis.port=7006",
3737
"mysql.db.name=WeightedMultiLevelQueueListener",
38-
"otp.queue.active=true",
38+
"sms.queue.active=true",
3939
"notification.queue.active=false",
4040
"email.queue.active=false",
4141
"job.queue.active=false",

rqueue-spring/src/test/java/com/github/sonus21/rqueue/spring/tests/integration/WeightedPriorityQueueListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
properties = {
3636
"spring.redis.port=7010",
3737
"mysql.db.name=WeightedPriorityQueueListener",
38-
"otp.queue.active=false",
38+
"sms.queue.active=false",
3939
"notification.queue.active=false",
4040
"email.queue.active=false",
4141
"job.queue.active=false",

0 commit comments

Comments
 (0)