Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth to have .pylintrc file? #3931

Open
pmoravec opened this issue Feb 14, 2025 · 1 comment
Open

Worth to have .pylintrc file? #3931

pmoravec opened this issue Feb 14, 2025 · 1 comment

Comments

@pmoravec
Copy link
Contributor

As various people use various pylint setup, is it worth having .pylintrc config that is aligned with our "Flake8 linting test" one?

@arif-ali
Copy link
Member

arif-ali commented Feb 14, 2025

I did try to align it as close as possible.

I tried to run flake8 manually on the code with latest version in unstable Debian, and I couldn't see that lint issue that was presented.

But, the pylintrc is what has been done so far, and there is probably still room for improvement. The pylint has many more checks and requirements compared to flake8, and hence why it took so many PRs, specifically from Pon, to get to this point

If anyone wants to take these off the list of improvements, then that's extra tasks that people can accomplish.

Was there a specific test you was looking to align?

If people want to run pylint and flake8 before uploading, then they can use the following 2 commands, this would be in-line with what we have and what we run on CI

tox -e flake8
tox -e pylint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants