Handle cases where kadi events come from maude (#196)

Do not treat observations without level 0 as errors (this is common since kadi uses maude for events)

Author: javierggt

agasc/supplement/magnitudes/mag_estimate.py

@@ -47,16 +47,16 @@
 
 
 EXCEPTION_MSG = {
-    -1: "Unknown",
     0: "OK",
     1: "No level 0 data",
     2: "No telemetry data",
     3: "Mismatch in telemetry between aca_l0 and cheta",
     4: "Time mismatch between cheta and level0",
     5: "Failed job",
     6: "Suspect observation",
+    1000: "Unknown",
 }
-EXCEPTION_CODES = collections.defaultdict(lambda: -1)
+EXCEPTION_CODES = collections.defaultdict(lambda: 1000)
 EXCEPTION_CODES.update({msg: code for code, msg in EXCEPTION_MSG.items() if code > 0})
 
 
@@ -92,6 +92,16 @@ def __init__(
                 "traceback": "\n".join(stack_trace),
             }
 
+    def _failed_(self):
+        """
+        Check if the exception is a failure.
+
+        :return: bool
+        """
+        return self.error_code > 1
+
+    failed = property(_failed_)
+
     def __str__(self):
         return (
             f"MagStatsException: {self.msg} (agasc_id: {self.agasc_id}, "
@@ -1310,12 +1320,12 @@ def get_agasc_id_stats(agasc_id, obs_status_override=None, tstop=None):
                 {
                     "obs_ok": False,
                     "obs_suspect": False,
-                    "obs_fail": True,
+                    "obs_fail": e.failed,
                     "comments": comment if excluded_obs[i] else f"Error: {e.msg}.",
                 }
             )
             stats.append(obs_stat)
-            if not excluded_obs[i]:
+            if e.failed and not excluded_obs[i]:
                 logger.debug(
                     f"  Error in get_agasc_id_stats({agasc_id=},"
                     f" obsid={obs['obsid']}): {e}"
@@ -1351,9 +1361,7 @@ def get_agasc_id_stats(agasc_id, obs_status_override=None, tstop=None):
 
     if len(all_telem) - len(failures) <= 0:
         # and we reach here if some observations were not flagged as bad, but all failed.
-        logger.debug(
-            f"  Error in get_agasc_id_stats({agasc_id=}): There is no OK observation."
-        )
+        logger.debug(f"  get_agasc_id_stats({agasc_id=}): There is no OK observation.")
         return result, stats, failures
 
     excluded_obs += np.array([t is None for t in all_telem])