remember to return an error when the HEAD response is not 200 OK

chrismwendt · chrismwendt · commit 97ca087a48a4 · 2018-12-14T16:20:17.000-08:00
diff --git a/vfsutil/zip.go b/vfsutil/zip.go
@@ -31,7 +31,7 @@ func NewZipVFS(ctx context.Context, url string, onFetchStart, onFetchFailed func
 		return nil, err
 	}
 	if response.StatusCode != http.StatusOK {
-		return nil, nil
+		return nil, fmt.Errorf("unable to fetch zip from %s (expected HTTP response code 200, but got %d)", url, response.StatusCode)
 	}
 
 	fetch := func(ctx context.Context) (ar *archiveReader, err error) {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ func NewZipVFS(ctx context.Context, url string, onFetchStart, onFetchFailed func`
`31`	`31`	`return nil, err`
`32`	`32`	`}`
`33`	`33`	`if response.StatusCode != http.StatusOK {`
`34`		`- return nil, nil`
	`34`	`+ return nil, fmt.Errorf("unable to fetch zip from %s (expected HTTP response code 200, but got %d)", url, response.StatusCode)`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`fetch := func(ctx context.Context) (ar *archiveReader, err error) {`