Костюмы для стриптиза#529
Conversation
Проверки PRPR #529, коммит
Падений в актуальных запусках пока нет. |
|
RSI Diff Bot; head commit a1ade85 merging into b3919bf Resources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi
Resources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi
|
📝 WalkthroughОбзорДобавляются два новых предмета одежды для стриптизёров (slim suit и star pasties suit) с локализацией на английском и русском языках, прототипами сущностей, метаданными текстур и записями в инвентаре торгового автомата. Изменения
Оценка трудозатрат на проверку кода🎯 1 (Тривиальный) | ⏱️ ~3 минуты Рекомендуемые метки
Стихотворение
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 errors)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@Resources/Prototypes/_Lust/Entities/Clothing/Uniforms/Jumpsuit/stripper_slimsuit.yml`:
- Line 3: The fork-unique prototype ID "ClothingStripperSlimSuit" lacks the
required Sunrise prefix; rename the prototype ID to
"SunriseClothingStripperSlimSuit" in the YAML (update the id field) and then
update every reference to that prototype (inventory entries, FTL/dialogue keys,
and any code or data that references ClothingStripperSlimSuit) to use the new
Sunrise-prefixed ID so links remain consistent; ensure you also update any
localization/FTL keys that include the old ID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4ab2b2b8-52b6-456a-8d1a-2630bccf454e
⛔ Files ignored due to path filters (8)
Resources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi/inhand-right.pngis excluded by!**/*.png
📒 Files selected for processing (9)
Resources/Locale/en-US/_prototypes/_lust/entities/clothing/uniforms/jumpsuit/stripper_slimsuit.ftlResources/Locale/en-US/_prototypes/_lust/entities/clothing/uniforms/jumpsuit/stripper_starpastiessuit.ftlResources/Locale/ru-RU/_prototypes/_lust/entities/clothing/uniforms/jumpsuit/stripper_slimsuit.ftlResources/Locale/ru-RU/_prototypes/_lust/entities/clothing/uniforms/jumpsuit/stripper_starpastiessuit.ftlResources/Prototypes/Catalog/VendingMachines/Inventories/theater.ymlResources/Prototypes/_Lust/Entities/Clothing/Uniforms/Jumpsuit/stripper_slimsuit.ymlResources/Prototypes/_Lust/Entities/Clothing/Uniforms/Jumpsuit/stripper_starpastiessuit.ymlResources/Textures/_Lust/Clothing/Uniforms/stripper_slimsuit.rsi/meta.jsonResources/Textures/_Lust/Clothing/Uniforms/stripper_starpastiessuit.rsi/meta.json
| @@ -0,0 +1,10 @@ | |||
| - type: entity | |||
| parent: ClothingUniformBase | |||
| id: ClothingStripperSlimSuit | |||
There was a problem hiding this comment.
Нарушен формат ID для fork-уникального прототипа.
ClothingStripperSlimSuit добавлен как новый fork-контент, но без обязательного префикса Sunrise. Переименуйте ID (например, SunriseClothingStripperSlimSuit) и синхронизируйте ссылки в инвентаре и FTL-ключах.
Предлагаемая правка (в этом файле)
- id: ClothingStripperSlimSuit
+ id: SunriseClothingStripperSlimSuitAs per coding guidelines, "Fail if changed content files violate ... fork-only prototype IDs missing a Sunrise prefix when they are unique fork content or forked copies of vanilla entities".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| id: ClothingStripperSlimSuit | |
| id: SunriseClothingStripperSlimSuit |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@Resources/Prototypes/_Lust/Entities/Clothing/Uniforms/Jumpsuit/stripper_slimsuit.yml`
at line 3, The fork-unique prototype ID "ClothingStripperSlimSuit" lacks the
required Sunrise prefix; rename the prototype ID to
"SunriseClothingStripperSlimSuit" in the YAML (update the id field) and then
update every reference to that prototype (inventory entries, FTL/dialogue keys,
and any code or data that references ClothingStripperSlimSuit) to use the new
Sunrise-prefixed ID so links remain consistent; ensure you also update any
localization/FTL keys that include the old ID.
|
бредик |
| @@ -0,0 +1,2 @@ | |||
| ent-ClothingStripperSlimSuit = slim stripper suit | |||
There was a problem hiding this comment.
Локаль в один файл надо засунуть, не надо плодить кучу файлов ради одной-двух строчек
| @@ -0,0 +1,2 @@ | |||
| ent-ClothingStripperStarPastiesSuit = star pasties stripper suit | |||
There was a problem hiding this comment.
Локаль в один файл надо засунуть, не надо плодить кучу файлов ради одной-двух строчек
| @@ -0,0 +1,2 @@ | |||
| ent-ClothingStripperSlimSuit = тонкий костюм стриптизёра | |||
There was a problem hiding this comment.
Локаль в один файл надо засунуть, не надо плодить кучу файлов ради одной-двух строчек
| @@ -0,0 +1,2 @@ | |||
| ent-ClothingStripperStarPastiesSuit = наклейки на соски | |||
There was a problem hiding this comment.
Локаль в один файл надо засунуть, не надо плодить кучу файлов ради одной-двух строчек
| @@ -0,0 +1,10 @@ | |||
| - type: entity | |||
| parent: ClothingUniformBase | |||
| id: ClothingStripperSlimSuit | |||
There was a problem hiding this comment.
Что за не консистентность наименования айди?
почему за базу комбинезоны взяты а по факту в айди нет упоминания?
того же касается и остальных
There was a problem hiding this comment.
В один файл надо закинуть, не надо плодить кучу, это фактически комбинезоны, то и хранится прототипы должны там
| # Lust-Start | ||
| ClothingBeerCostume: 2 | ||
| ClothingPivozavr: 2 | ||
| ClothingStripperSlimSuit: 2 |
There was a problem hiding this comment.
Разве такое не у платье шкафа или у ластовского ерп вендора должно быть?
4 participants
Краткое описание | Short description
Добавление одежды для проституции(и не только).
Медиа (Видео/Скриншоты) | Media (Video/Screenshots)
Наклейка на соски:
Костюм:
Changelog
🆑 LemonFY
Summary by CodeRabbit
Новые функции