Skip to content

The SS14.Client.zip will get authenticated if authentication is enabled #8

@VasilisThePikachu

Description

@VasilisThePikachu

Super minor, but it may come back to bite us later on, so I thought to make an issue

We have a password auth on the API, this is good to protect someone from just downloading a server if we have a special fork. That is excellent!

However, this seems to lock down the entire GET /fork/FORK path base. Which will mean it will block an attempt to fetch SS14.Client.zip to download

Why is this bad?

It's not too bad, honestly, no part of the client will actually ever need to zip file directly.

But I find it counterintuitive it would be blocked, the client will get the client anyway via delta.

It also means that if we ever decide to implement the discussed zip range downloads + CDN for client downloads, we MAY have issues in the future

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions