Merge pull request #6300 from specify/issue-6299

Only change CO -> catNum for new COs when COT changes

Author: melton-jason

specifyweb/frontend/js_src/lib/components/DataModel/__tests__/businessRules.test.ts

@@ -191,14 +191,15 @@ describe('Collection Object business rules', () => {
     await collectionObject.businessRuleManager?.pendingPromise;
   });
 
-  test('CollectionObject -> catalogNumber is reset whenever existing CollectionObject -> collectionObjectType changes', async () => {
+  test('CollectionObject -> catalogNumber is not reset whenever existing CollectionObject -> collectionObjectType changes', async () => {
     const collectionObject = getBaseCollectionObject();
-    expect(collectionObject.get('catalogNumber')).toBe('123');
+    const expectedCatNumber = '123';
+    expect(collectionObject.get('catalogNumber')).toBe(expectedCatNumber);
     collectionObject.set(
       'collectionObjectType',
       getResourceApiUrl('CollectionObjectType', 2)
     );
-    expect(collectionObject.get('catalogNumber')).toBe('2022-######');
+    expect(collectionObject.get('catalogNumber')).toBe(expectedCatNumber);
     // Wait for any pending promise to complete before test finishes
     await collectionObject.businessRuleManager?.pendingPromise;
   });

specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts

@@ -182,15 +182,17 @@ export const businessRuleDefs: MappedBusinessRuleDefs = {
     },
     fieldChecks: {
       collectionObjectType: async (resource): Promise<undefined> => {
-        const parser = resolveParser(
-          resource.specifyTable.strictGetLiteralField('catalogNumber'),
-          undefined,
-          resource
-        );
-        // REFACTOR: non-silent set causes infinite loop and silent set still triggers save blocker when parser value is empty string
-        resource.set('catalogNumber', parser.value as never, {
-          silent: (parser.value ?? '') === '',
-        });
+        if (resource.isNew()) {
+          const parser = resolveParser(
+            resource.specifyTable.strictGetLiteralField('catalogNumber'),
+            undefined,
+            resource
+          );
+          // REFACTOR: non-silent set causes infinite loop and silent set still triggers save blocker when parser value is empty string
+          resource.set('catalogNumber', parser.value as never, {
+            silent: (parser.value ?? '') === '',
+          });
+        }
 
         const determinations = resource.getDependentResource('determinations');
         if (determinations === undefined || determinations.models.length === 0)