Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment CSS class is to ambiguous on its own #57

Closed
Piralein opened this issue Feb 4, 2025 · 1 comment · Fixed by #58
Closed

Alignment CSS class is to ambiguous on its own #57

Piralein opened this issue Feb 4, 2025 · 1 comment · Fixed by #58

Comments

@Piralein
Copy link
Contributor

Piralein commented Feb 4, 2025

Problem:

The PR #40 hard-coded the align-* classes to the container surrounding the video element.
This classes are already used in different themes or may be used as part of custom themes with different CSS definitions or use cases as the ones assumed by this extension.

It is currently not possible to add an additional class to the container with the configuration, this results in the container being not distinguishable as part of this extension.

Proposal:

Add an additional class to the container to properly mark it as part of this extension, so its CSS definitions can be overridden.
.align-left.sphinx-contrib-video-container {...}

Or add an additional :class: config for the container.

@12rambau
Copy link
Member

12rambau commented Feb 6, 2025

I think the easiest would be to add the class parameter to the container. I aligned the align-* class to match the one used by Sphinx for images.

Would you be ok to make a PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants