Cease using flake8 (#13204)

Author: AA-Turner

.flake8

@@ -45,28 +45,6 @@ jobs:
     - name: Format with Ruff
       run: ruff format . --diff
 
-  flake8:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v4
-      with:
-        persist-credentials: false
-    - name: Set up Python
-      uses: actions/setup-python@v5
-      with:
-        python-version: "3"
-    - name: Install uv
-      run: >
-        curl --no-progress-meter --location --fail
-        --proto '=https' --tlsv1.2
-        "https://astral.sh/uv/install.sh"
-        | sh
-    - name: Install dependencies
-      run: uv pip install --upgrade "flake8>=6.0"
-    - name: Lint with flake8
-      run: flake8 .
-
   mypy:
     runs-on: ubuntu-latest
 

.github/workflows/lint.yml

@@ -77,7 +77,6 @@ ignore = [
     "UP032",   # Use f-string instead of `format` call
 ]
 external = [  # Whitelist for RUF100 unknown code warnings
-    "E704",
     "SIM113",
 ]
 select = [

.ruff.toml

@@ -45,7 +45,6 @@ clean: clean
 
 .PHONY: style-check
 style-check:
-	@echo '[+] running flake8' ; flake8 .
 	@echo '[+] running ruff' ; ruff check .
 
 .PHONY: format

Makefile

@@ -81,7 +81,6 @@ docs = [
     "sphinxcontrib-websupport",
 ]
 lint = [
-    "flake8>=6.0",
     "ruff==0.8.1",
     "mypy==1.13.0",
     "sphinx-lint>=0.9",

pyproject.toml

@@ -505,23 +505,23 @@ def require_sphinx(version: tuple[int, int] | str) -> None:
     # ---- Core events -------------------------------------------------------
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['config-inited'],
         callback: Callable[[Sphinx, Config], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['builder-inited'],
         callback: Callable[[Sphinx], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-get-outdated'],
         callback: Callable[
@@ -531,47 +531,47 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-before-read-docs'],
         callback: Callable[[Sphinx, BuildEnvironment, list[str]], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-purge-doc'],
         callback: Callable[[Sphinx, BuildEnvironment, str], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['source-read'],
         callback: Callable[[Sphinx, str, list[str]], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['include-read'],
         callback: Callable[[Sphinx, Path, str, list[str]], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['doctree-read'],
         callback: Callable[[Sphinx, nodes.document], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-merge-info'],
         callback: Callable[
@@ -581,47 +581,47 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-updated'],
         callback: Callable[[Sphinx, BuildEnvironment], str],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-get-updated'],
         callback: Callable[[Sphinx, BuildEnvironment], Iterable[str]],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['env-check-consistency'],
         callback: Callable[[Sphinx, BuildEnvironment], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['write-started'],
         callback: Callable[[Sphinx, Builder], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['doctree-resolved'],
         callback: Callable[[Sphinx, nodes.document, str], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['missing-reference'],
         callback: Callable[
@@ -632,15 +632,15 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['warn-missing-reference'],
         callback: Callable[[Sphinx, Domain, addnodes.pending_xref], bool | None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['build-finished'],
         callback: Callable[[Sphinx, Exception | None], None],
@@ -650,15 +650,15 @@ def connect(  # NoQA: E704
     # ---- Events from builtin builders --------------------------------------
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['html-collect-pages'],
         callback: Callable[[Sphinx], Iterable[tuple[str, dict[str, Any], str]]],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['html-page-context'],
         callback: Callable[
@@ -668,7 +668,7 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['linkcheck-process-uri'],
         callback: Callable[[Sphinx, str], str | None],
@@ -678,7 +678,7 @@ def connect(  # NoQA: E704
     # ---- Events from builtin extensions-- ----------------------------------
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['object-description-transform'],
         callback: Callable[[Sphinx, str, str, addnodes.desc_content], None],
@@ -688,23 +688,23 @@ def connect(  # NoQA: E704
     # ---- Events from first-party extensions --------------------------------
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['autodoc-process-docstring'],
         callback: _AutodocProcessDocstringListener,
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['autodoc-before-process-signature'],
         callback: Callable[[Sphinx, Any, bool], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['autodoc-process-signature'],
         callback: Callable[
@@ -725,15 +725,15 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['autodoc-process-bases'],
         callback: Callable[[Sphinx, str, Any, dict[str, bool], list[str]], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['autodoc-skip-member'],
         callback: Callable[
@@ -753,15 +753,15 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['todo-defined'],
         callback: Callable[[Sphinx, todo_node], None],
         priority: int = 500,
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['viewcode-find-source'],
         callback: Callable[
@@ -772,7 +772,7 @@ def connect(  # NoQA: E704
     ) -> int: ...
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: Literal['viewcode-follow-imported'],
         callback: Callable[[Sphinx, str, str], str | None],
@@ -782,7 +782,7 @@ def connect(  # NoQA: E704
     # ---- Catch-all ---------------------------------------------------------
 
     @overload
-    def connect(  # NoQA: E704
+    def connect(
         self,
         event: str,
         callback: Callable[..., Any],
@@ -1405,7 +1405,7 @@ def add_transform(self, transform: type[Transform]) -> None:
         refs: `Transform Priority Range Categories`__
 
         __ https://docutils.sourceforge.io/docs/ref/transforms.html#transform-priority-range-categories
-        """  # NoQA: E501,RUF100  # Flake8 thinks the URL is too long, Ruff special cases URLs.
+        """
         self.registry.add_transform(transform)
 
     def add_post_transform(self, transform: type[Transform]) -> None:

sphinx/application.py

@@ -32,7 +32,7 @@
     from typing import Protocol
 
     class SupportsWrite(Protocol):
-        def write(self, text: str, /) -> int | None: ...  # NoQA: E704
+        def write(self, text: str, /) -> int | None: ...
 
 
 def handle_exception(