metrics not confirming promtool

[alitta-german]

Hi,

Prometheus suggests metrics naming, and it provides a tool to check them:
https://prometheus.io/docs/prometheus/latest/command-line/promtool/#promtool-check-metrics

I've checked it, and it failed on 65 metrics:
spire_agent_agent_key_manager_generate_key counter metrics should have "_total" suffix
spire_agent_agent_key_manager_get_keys counter metrics should have "_total" suffix
spire_agent_lru_cache_entry_add counter metrics should have "_total" suffix
spire_agent_lru_cache_entry_remove counter metrics should have "_total" suffix
spire_agent_lru_cache_entry_update counter metrics should have "_total" suffix
spire_agent_manager_sync_fetch_entries_updates counter metrics should have "_total" suffix
spire_agent_manager_sync_fetch_svids_updates counter metrics should have "_total" suffix
spire_agent_node_attestor_new_svid counter metrics should have "_total" suffix
spire_agent_rpc_health_check counter metrics should have "_total" suffix
spire_agent_rpc_workload_api_fetch_x509_bundles counter metrics should have "_total" suffix
spire_agent_rpc_workload_api_fetch_x509svid counter metrics should have "_total" suffix
spire_agent_runtime_free_count non-histogram and non-summary metrics should not have "_count" suffix
spire_agent_runtime_gc_pause_ns metric names should not contain abbreviated units
spire_agent_runtime_malloc_count non-histogram and non-summary metrics should not have "_count" suffix
spire_agent_runtime_total_gc_pause_ns metric names should not contain abbreviated units
spire_agent_store_store_svid_updates counter metrics should have "_total" suffix
spire_agent_uptime_in_ms metric names should not contain abbreviated units
spire_agent_workload_api_connection counter metrics should have "_total" suffix
spire_agent_workload_api_workload_attestation counter metrics should have "_total" suffix
spire_agent_workload_api_workload_attestor counter metrics should have "_total" suffix
spire_server_ca_manager_jwt_key_prepare counter metrics should have "_total" suffix
spire_server_ca_manager_x509_ca_activate counter metrics should have "_total" suffix
spire_server_ca_manager_x509_ca_prepare counter metrics should have "_total" suffix
spire_server_datastore_bundle_append counter metrics should have "_total" suffix
spire_server_datastore_bundle_fetch counter metrics should have "_total" suffix
spire_server_datastore_ca_journal_set counter metrics should have "_total" suffix
spire_server_datastore_federation_relationship_list counter metrics should have "_total" suffix
spire_server_datastore_node_create counter metrics should have "_total" suffix
spire_server_datastore_node_fetch counter metrics should have "_total" suffix
spire_server_datastore_node_list counter metrics should have "_total" suffix
spire_server_datastore_node_selectors_list counter metrics should have "_total" suffix
spire_server_datastore_node_selectors_set counter metrics should have "_total" suffix
spire_server_datastore_registration_entry_create counter metrics should have "_total" suffix
spire_server_datastore_registration_entry_delete counter metrics should have "_total" suffix
spire_server_datastore_registration_entry_list counter metrics should have "_total" suffix
spire_server_datastore_registration_entry_update counter metrics should have "_total" suffix
spire_server_entry_cache_reload counter metrics should have "_total" suffix
spire_server_manager_jwt_key_activate counter metrics should have "_total" suffix
spire_server_rateLimit_agent_v1_agent_attest_agent counter metrics should have "_total" suffix
spire_server_rateLimit_agent_v1_agent_attest_agent metric names should be written in 'snake_case' not 'camelCase'
spire_server_rateLimit_agent_v1_agent_attest_agent_elapsed_time metric names should be written in 'snake_case' not 'camelCase'
spire_server_rateLimit_svid_v1_svid_batch_new_x509svid counter metrics should have "_total" suffix
spire_server_rateLimit_svid_v1_svid_batch_new_x509svid metric names should be written in 'snake_case' not 'camelCase'
spire_server_rateLimit_svid_v1_svid_batch_new_x509svid_elapsed_time metric names should be written in 'snake_case' not 'camelCase'
spire_server_rpc_agent_v1_agent_attest_agent counter metrics should have "_total" suffix
spire_server_rpc_bundle_v1_bundle_get_bundle counter metrics should have "_total" suffix
spire_server_rpc_entry_v1_entry_batch_create_entry counter metrics should have "_total" suffix
spire_server_rpc_entry_v1_entry_batch_delete_entry counter metrics should have "_total" suffix
spire_server_rpc_entry_v1_entry_batch_update_entry counter metrics should have "_total" suffix
spire_server_rpc_entry_v1_entry_get_authorized_entries counter metrics should have "_total" suffix
spire_server_rpc_entry_v1_entry_list_entries counter metrics should have "_total" suffix
spire_server_rpc_health_check counter metrics should have "_total" suffix
spire_server_rpc_logger_get_logger counter metrics should have "_total" suffix
spire_server_rpc_svid_v1_svid_batch_new_x509svid counter metrics should have "_total" suffix
spire_server_rpc_svid_v1_svid_mint_x509svid counter metrics should have "_total" suffix
spire_server_rpc_trustdomain_v1_trust_domain_list_federation_relationships counter metrics should have "_total" suffix
spire_server_runtime_free_count non-histogram and non-summary metrics should not have "_count" suffix
spire_server_runtime_gc_pause_ns metric names should not contain abbreviated units
spire_server_runtime_malloc_count non-histogram and non-summary metrics should not have "_count" suffix
spire_server_runtime_total_gc_pause_ns metric names should not contain abbreviated units
spire_server_server_ca_sign_x509_svid counter metrics should have "_total" suffix
spire_server_server_key_manager_generate_key counter metrics should have "_total" suffix
spire_server_server_key_manager_get_public_keys counter metrics should have "_total" suffix
spire_server_svid_rotate counter metrics should have "_total" suffix
spire_server_uptime_in_ms metric names should not contain abbreviated units

And if the metrics are touched, then all of the metrics should have a proper "HELP" text, for example:
#HELP spire_server_ca_manager_x509_ca_activate spire_server_ca_manager_x509_ca_activate
#TYPE spire_server_ca_manager_x509_ca_activate counter

In this example, the help text just repeats the metric's name, which is not very helpful.