Merge pull request JanKaul#223 from JanKaul/more-context-for-unimplemented

provide more context for unimplemented macro

Author: JanKaul

.github/workflows/rust.yml

@@ -13,6 +13,16 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
+    - name: Free disk space
+      uses: jlumbroso/free-disk-space@main
+      with:
+        tool-cache: false
+        android: true
+        dotnet: true
+        haskell: true
+        large-packages: false
+        docker-images: false
+        swap-storage: false
     - uses: actions/checkout@v3
     - name: Build
       run: cargo build --verbose

Makefile

@@ -7,16 +7,16 @@ test-iceberg-rust:
 	cargo test -p iceberg-rust --lib
 
 test-datafusion_iceberg:
-	cargo test -p datafusion_iceberg --tests -j 2 && cargo clean -p datafusion_iceberg
+	cargo test -p datafusion_iceberg --tests -j 2 
 
 test-rest-catalog:
-	cargo test -p iceberg-rest-catalog --lib && cargo clean -p iceberg-rest-catalog
+	cargo test -p iceberg-rest-catalog --lib 
 
 test-file-catalog:
-	cargo test -p iceberg-file-catalog --lib && cargo clean -p iceberg-file-catalog
+	cargo test -p iceberg-file-catalog --lib 
 
 test-sql-catalog:
-	cargo test -p iceberg-sql-catalog --lib && cargo clean -p iceberg-sql-catalog
+	cargo test -p iceberg-sql-catalog --lib 
 clippy:
 	cargo clippy --all-targets --all-features -- -D warnings
 fmt:

catalogs/iceberg-file-catalog/src/lib.rs

@@ -506,7 +506,7 @@ impl Catalog for FileCatalog {
         _identifier: Identifier,
         _metadata_location: &str,
     ) -> Result<Table, IcebergError> {
-        unimplemented!()
+        unimplemented!("Register table for file catalog")
     }
 }
 

iceberg-rust-spec/src/spec/table_metadata.rs

@@ -892,6 +892,15 @@ impl From<FormatVersion> for u8 {
     }
 }
 
+impl From<FormatVersion> for i32 {
+    fn from(value: FormatVersion) -> Self {
+        match value {
+            FormatVersion::V1 => 1,
+            FormatVersion::V2 => 2,
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
 

iceberg-rust-spec/src/spec/values.rs

@@ -670,7 +670,7 @@ impl Value {
                 precision: 38,
                 scale: dec.scale(),
             }),
-            _ => unimplemented!(),
+            _ => unimplemented!("Datatype for value"),
         }
     }
 
@@ -698,7 +698,7 @@ impl Value {
             Value::String(any) => Box::new(any),
             Value::UUID(any) => Box::new(any),
             Value::Decimal(any) => Box::new(any),
-            _ => unimplemented!(),
+            _ => unimplemented!("Value conversion to any"),
         }
     }
 

iceberg-rust-spec/src/spec/view_metadata.rs

@@ -301,6 +301,14 @@ impl From<FormatVersion> for u8 {
     }
 }
 
+impl From<FormatVersion> for i32 {
+    fn from(value: FormatVersion) -> Self {
+        match value {
+            FormatVersion::V1 => 1,
+        }
+    }
+}
+
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone, Default, Builder, Getters)]
 #[serde(rename_all = "kebab-case")]
 /// Fields for the version 2 of the view metadata.

iceberg-rust/src/catalog/commit.rs

@@ -420,10 +420,10 @@ pub fn apply_table_updates(
     for update in updates {
         match update {
             TableUpdate::UpgradeFormatVersion { format_version } => {
-                if u8::from(metadata.format_version) == format_version as u8 {
+                if i32::from(metadata.format_version) == format_version {
                     return Ok(());
                 }
-                unimplemented!();
+                unimplemented!("Table format upgrade");
             }
             TableUpdate::AssignUuid { uuid } => {
                 metadata.table_uuid = Uuid::parse_str(&uuid)?;
@@ -519,8 +519,11 @@ pub fn apply_view_updates<T: Materialization + 'static>(
 ) -> Result<(), Error> {
     for update in updates {
         match update {
-            ViewUpdate::UpgradeFormatVersion { format_version: _ } => {
-                unimplemented!();
+            ViewUpdate::UpgradeFormatVersion { format_version } => {
+                if i32::from(metadata.format_version.clone()) == format_version {
+                    return Ok(());
+                }
+                unimplemented!("Upgrade of format version");
             }
             ViewUpdate::AssignUuid { uuid } => {
                 metadata.view_uuid = Uuid::parse_str(&uuid)?;