Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GHA workflow script execution able to run in parallel #2092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Jan 23, 2025

No description provided.

Copy link
Member Author

Vampire commented Jan 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (f350b52) to head (5e6b095).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2092      +/-   ##
============================================
- Coverage     81.92%   81.89%   -0.04%     
+ Complexity     4687     4686       -1     
============================================
  Files           452      452              
  Lines         14678    14678              
  Branches       1847     1847              
============================================
- Hits          12025    12020       -5     
- Misses         1972     1976       +4     
- Partials        681      682       +1     

see 2 files with indirect coverage changes

@leonard84
Copy link
Member

.github\workflows\codeql-analysis.main.kts: error: java.nio.file.AccessDeniedException: C:\Users\runneradmin.m2\repository\io\github\typesafegithub\github-workflows-kt\3.2.0_remote.repositories4916797036625729504tmp -> C:\Users\runneradmin.m2\repository\io\github\typesafegithub\github-workflows-kt\3.2.0_remote.repositories

Does this change introduce resource conflicts?

@Vampire
Copy link
Member Author

Vampire commented Jan 30, 2025

Hm, seems there is a race condition when .main.kts scripts are run in parallel when trying to write to Maven Local repository. :-(
https://youtrack.jetbrains.com/issue/KT-74830
I added a retry, that should work-around it hopefully.

@Vampire Vampire force-pushed the vampire/improve-workflow-script-execution branch from dd2a0fd to 5e6b095 Compare January 30, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants