Skip to content

Commit 205b2bc

Browse files
fix: Reason value
1 parent 91ad268 commit 205b2bc

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Sources/ConfidenceProvider/ConfidenceFeatureProvider.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ extension Evaluation {
148148
return ProviderEvaluation(
149149
value: self.value,
150150
variant: self.variant,
151-
reason: Reason.targetingMatch.rawValue, // TODO VERIFY THIS!
151+
reason: self.reason.rawValue,
152152
errorCode: nil,
153153
errorMessage: nil
154154
)
@@ -162,7 +162,7 @@ extension Evaluation where T == [String: Any] {
162162
return ProviderEvaluation(
163163
value: openFeatureValue,
164164
variant: self.variant,
165-
reason: Reason.targetingMatch.rawValue, // TODO VERIFY THIS!
165+
reason: self.reason.rawValue,
166166
errorCode: nil,
167167
errorMessage: nil
168168
)

Tests/ConfidenceProviderTests/ConfidenceProviderTest.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ class ConfidenceProviderTest: XCTestCase {
228228
// Verify the converted value is correct
229229
XCTAssertEqual(resultMap["int"], .integer(42))
230230
XCTAssertEqual(evaluation.variant, "variant1")
231-
XCTAssertEqual(evaluation.reason, "targetingMatch")
231+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
232232
}
233233

234234
func testProviderResolveStruct() async throws {
@@ -277,7 +277,7 @@ class ConfidenceProviderTest: XCTestCase {
277277

278278
XCTAssertEqual(resultMap["size"], .integer(3))
279279
XCTAssertEqual(evaluation.variant, "control")
280-
XCTAssertEqual(evaluation.reason, "targetingMatch")
280+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
281281
XCTAssertNil(evaluation.errorCode)
282282
XCTAssertNil(evaluation.errorMessage)
283283
}
@@ -333,7 +333,7 @@ class ConfidenceProviderTest: XCTestCase {
333333

334334
XCTAssertEqual(sizeMap["border"], .integer(420))
335335
XCTAssertEqual(evaluation.variant, "control")
336-
XCTAssertEqual(evaluation.reason, "targetingMatch")
336+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
337337
}
338338

339339
func testProviderResolveStructSchemaMismatch() async throws {
@@ -434,7 +434,7 @@ class ConfidenceProviderTest: XCTestCase {
434434
XCTAssertEqual(resultMap["width"], .integer(200))
435435
XCTAssertNil(resultMap["height"])
436436
XCTAssertEqual(evaluation.variant, "control")
437-
XCTAssertEqual(evaluation.reason, "targetingMatch")
437+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
438438
}
439439

440440
func testProviderResolveStructHeterogenous() async throws {
@@ -487,7 +487,7 @@ class ConfidenceProviderTest: XCTestCase {
487487
XCTAssertEqual(resultMap["width"], .integer(200))
488488
XCTAssertEqual(resultMap["color"], .string("yellow"))
489489
XCTAssertEqual(evaluation.variant, "control")
490-
XCTAssertEqual(evaluation.reason, "targetingMatch")
490+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
491491
}
492492

493493
func testProviderResolveStructHeterogenousExtraValueInFlag() async throws {
@@ -542,7 +542,7 @@ class ConfidenceProviderTest: XCTestCase {
542542
XCTAssertEqual(resultMap["color"], .string("yellow"))
543543
XCTAssertNil(resultMap["error"])
544544
XCTAssertEqual(evaluation.variant, "control")
545-
XCTAssertEqual(evaluation.reason, "targetingMatch")
545+
XCTAssertEqual(evaluation.reason, "RESOLVE_REASON_MATCH")
546546
}
547547

548548
func testProviderResolveStructHeterogenousExtraValueInDefaultValue() async throws {

0 commit comments

Comments
 (0)