Fix regression in custom conversion ordering.

This commit fixes a regression that prevented user provided custom converters from taking precedence over framework defined ones.

Author: christophstrobl

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoCustomConversions.java

@@ -378,7 +378,7 @@ ConverterConfiguration createConverterConfiguration() {
 
 			if (!useNativeDriverJavaTimeCodecs) {
 
-				converters.addAll(customConverters);
+				converters.addAll(0, customConverters); // need to add at index 0!!
 				return new ConverterConfiguration(STORE_CONVERSIONS, converters, convertiblePair -> true,
 						this.propertyValueConversions);
 			}

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java

@@ -113,6 +113,7 @@
 import com.mongodb.BasicDBObject;
 import com.mongodb.DBObject;
 import com.mongodb.DBRef;
+import org.springframework.util.ObjectUtils;
 
 /**
  * Unit tests for {@link MappingMongoConverter}.
@@ -3410,11 +3411,38 @@ void usesStringNumericFormat() {
 		assertThat(document).containsEntry("map.foo", "2.5");
 	}
 
+	@Test // GH-5036
+	void withCustomBigIntegerConversion() {
+
+		MappingMongoConverter converter = createConverter(MongoCustomConversions.BigDecimalRepresentation.STRING,
+				new CustomBigIntegerToStringConverter());
+
+		WithBigNumericValues container = new WithBigNumericValues();
+		container.bigInteger = BigInteger.TEN;
+
+		org.bson.Document document = new org.bson.Document();
+		converter.write(container, document);
+
+		assertThat(document).containsEntry("bigInteger", "BigInteger('10')");
+	}
+
 	private MappingMongoConverter createConverter(
 			MongoCustomConversions.BigDecimalRepresentation bigDecimalRepresentation) {
 
-		MongoCustomConversions conversions = MongoCustomConversions.create(
-				it -> it.registerConverter(new ByteBufferToDoubleHolderConverter()).bigDecimal(bigDecimalRepresentation));
+		return createConverter(bigDecimalRepresentation, new ByteBufferToDoubleHolderConverter());
+	}
+
+	private MappingMongoConverter createConverter(
+			MongoCustomConversions.BigDecimalRepresentation bigDecimalRepresentation, Converter<?, ?>... customConverters) {
+
+		MongoCustomConversions conversions = MongoCustomConversions.create(it -> {
+			if (!ObjectUtils.isEmpty(customConverters)) {
+				for (Converter<?, ?> customConverter : customConverters) {
+					it.registerConverter(customConverter);
+				}
+			}
+			it.bigDecimal(bigDecimalRepresentation);
+		});
 
 		MongoMappingContext mappingContext = new MongoMappingContext();
 		mappingContext.setApplicationContext(context);
@@ -3437,6 +3465,14 @@ org.bson.Document write(Object source) {
 		return target;
 	}
 
+	@WritingConverter
+	static class CustomBigIntegerToStringConverter implements Converter<BigInteger, String> {
+		@Override
+		public String convert(BigInteger source) {
+			return "BigInteger('%s')".formatted(source.toString());
+		}
+	}
+
 	static class WithVector {
 
 		Vector embeddings;
@@ -4084,8 +4120,7 @@ static class WithExplicitTargetTypes {
 		@Field(targetType = FieldType.DECIMAL128) //
 		BigDecimal bigDecimal;
 
-		@Field(targetType = FieldType.DECIMAL128)
-		BigInteger bigInteger;
+		@Field(targetType = FieldType.DECIMAL128) BigInteger bigInteger;
 
 		@Field(targetType = FieldType.INT64) //
 		Date dateAsLong;
@@ -4100,6 +4135,10 @@ static class WithExplicitTargetTypes {
 		Date dateAsObjectId;
 	}
 
+	static class WithBigNumericValues {
+		BigInteger bigInteger;
+	}
+
 	static class WrapperAroundWithUnwrapped {
 
 		String someValue;