Skip to content

Commit 481057b

Browse files
Disable tests based on system architecture.
Redis has issues with numeric representation of floating point numbers which causes tests to fail on M1. See: redis/redis#3768 Closes: #2424
1 parent 8f37abe commit 481057b

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import static org.assertj.core.api.Assertions.*;
1919
import static org.assertj.core.api.Assumptions.*;
2020
import static org.awaitility.Awaitility.*;
21+
import static org.junit.jupiter.api.condition.OS.*;
2122
import static org.springframework.data.redis.connection.BitFieldSubCommands.*;
2223
import static org.springframework.data.redis.connection.BitFieldSubCommands.BitFieldIncrBy.Overflow.*;
2324
import static org.springframework.data.redis.connection.BitFieldSubCommands.BitFieldType.*;
@@ -41,7 +42,7 @@
4142
import org.junit.jupiter.api.BeforeEach;
4243
import org.junit.jupiter.api.Disabled;
4344
import org.junit.jupiter.api.Test;
44-
45+
import org.junit.jupiter.api.condition.DisabledOnOs;
4546
import org.springframework.beans.factory.annotation.Autowired;
4647
import org.springframework.dao.DataAccessException;
4748
import org.springframework.data.domain.Range;
@@ -1259,6 +1260,7 @@ void testDecrByIncrBy() {
12591260
}
12601261

12611262
@Test
1263+
@DisabledOnOs(value = MAC, architectures = "aarch64")
12621264
void testIncrByDouble() {
12631265

12641266
actual.add(connection.set("tdb", "4.5"));
@@ -2467,6 +2469,7 @@ void testHIncrBy() {
24672469
}
24682470

24692471
@Test
2472+
@DisabledOnOs(value = MAC, architectures = "aarch64")
24702473
void testHIncrByDouble() {
24712474
actual.add(connection.hSet("test", "key", "2.9"));
24722475
actual.add(connection.hIncrBy("test", "key", 3.5));
@@ -2648,6 +2651,7 @@ private static List<String> toList(Cursor<byte[]> cursor) {
26482651
}
26492652

26502653
@Test // DATAREDIS-417
2654+
@DisabledOnOs(value = MAC, architectures = "aarch64")
26512655
public void scanShouldReadEntireValueRangeWhenIdividualScanIterationsReturnEmptyCollection() {
26522656

26532657
connection.execute("DEBUG", "POPULATE".getBytes(), "100".getBytes());

src/test/java/org/springframework/data/redis/core/DefaultReactiveHashOperationsIntegrationTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717

1818
import static org.assertj.core.api.Assertions.*;
1919
import static org.assertj.core.api.Assumptions.*;
20+
import static org.junit.jupiter.api.condition.OS.*;
2021

22+
import org.junit.jupiter.api.condition.DisabledOnOs;
2123
import org.springframework.data.redis.connection.convert.Converters;
2224
import reactor.test.StepVerifier;
2325

@@ -305,6 +307,7 @@ void randomValue() {
305307
}
306308

307309
@ParameterizedRedisTest // DATAREDIS-602
310+
@DisabledOnOs(value = MAC, architectures = "aarch64")
308311
@SuppressWarnings("unchecked")
309312
void incrementDouble() {
310313

src/test/java/org/springframework/data/redis/core/DefaultReactiveValueOperationsIntegrationTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,13 @@
1717

1818
import static org.assertj.core.api.Assertions.*;
1919
import static org.junit.Assume.*;
20+
import static org.junit.jupiter.api.condition.OS.*;
2021
import static org.springframework.data.redis.connection.BitFieldSubCommands.*;
2122
import static org.springframework.data.redis.connection.BitFieldSubCommands.BitFieldIncrBy.Overflow.*;
2223
import static org.springframework.data.redis.connection.BitFieldSubCommands.BitFieldType.*;
2324
import static org.springframework.data.redis.connection.BitFieldSubCommands.Offset.offset;
2425

26+
import org.junit.jupiter.api.condition.DisabledOnOs;
2527
import reactor.test.StepVerifier;
2628

2729
import java.nio.ByteBuffer;
@@ -453,6 +455,7 @@ void incrementByLongDelta() {
453455
}
454456

455457
@ParameterizedRedisTest // DATAREDIS-784
458+
@DisabledOnOs(value = MAC, architectures = "aarch64")
456459
void incrementByFloatDelta() {
457460

458461
K key = keyFactory.instance();

0 commit comments

Comments
 (0)