Polishing.

Apply format and use instanceof pattern matching.

Original Pull Request: #3146

Author: christophstrobl

src/main/java/org/springframework/data/redis/core/convert/MappingRedisConverter.java

@@ -31,7 +31,6 @@
 import java.util.regex.Pattern;
 
 import org.jspecify.annotations.Nullable;
-
 import org.springframework.beans.factory.InitializingBean;
 import org.springframework.core.CollectionFactory;
 import org.springframework.core.convert.ConversionService;
@@ -173,7 +172,7 @@ public MappingRedisConverter(@Nullable RedisMappingContext mappingContext, @Null
 	}
 
 	@Override
-	@SuppressWarnings({"unchecked", "NullAway"})
+	@SuppressWarnings({ "unchecked", "NullAway" })
 	public <R> R read(Class<R> type, RedisData source) {
 
 		TypeInformation<?> readType = typeMapper.readType(source.getBucket().getPath(), TypeInformation.of(type));
@@ -188,8 +187,8 @@ public <R> R read(Class<R> type, RedisData source) {
 		return source.getBucket().isEmpty() ? null : doReadInternal(path, type, source);
 	}
 
-	@SuppressWarnings({"unchecked", "NullAway"})
-	private <R>  R doReadInternal(String path, Class<R> type, RedisData source) {
+	@SuppressWarnings({ "unchecked", "NullAway" })
+	private <R> R doReadInternal(String path, Class<R> type, RedisData source) {
 
 		TypeInformation<?> readType = typeMapper.readType(source.getBucket().getPath(), TypeInformation.of(type));
 
@@ -403,14 +402,8 @@ public void write(@Nullable Object source, RedisData sink) {
 			return;
 		}
 
-		if (source instanceof Collection) {
-			writeCollection(
-					sink.getKeyspace(),
-					"",
-					(List<?>) source,
-					TypeInformation.of(Object.class),
-					sink
-			);
+		if (source instanceof Collection collection) {
+			writeCollection(sink.getKeyspace(), "", collection, TypeInformation.of(Object.class), sink);
 			return;
 		}
 
@@ -432,8 +425,7 @@ public void write(@Nullable Object source, RedisData sink) {
 		sink.setKeyspace(keySpace);
 
 		if (entity.getTypeInformation().isCollectionLike()) {
-			writeCollection(keySpace, "", (List) source, entity.getTypeInformation().getRequiredComponentType(),
-					sink);
+			writeCollection(keySpace, "", (List) source, entity.getTypeInformation().getRequiredComponentType(), sink);
 		} else {
 			writeInternal(keySpace, "", source, entity.getTypeInformation(), sink);
 		}
@@ -562,8 +554,7 @@ private void writePartialPropertyUpdate(PartialUpdate<?> update, PropertyUpdate
 			writeMap(keySpace, pUpdate.getPropertyPath(), targetProperty.getMapValueType(), map, sink);
 		} else {
 
-			writeInternal(keySpace, pUpdate.getPropertyPath(), pUpdate.getValue(),
-					targetProperty.getTypeInformation(), sink);
+			writeInternal(keySpace, pUpdate.getPropertyPath(), pUpdate.getValue(), targetProperty.getTypeInformation(), sink);
 
 			Set<IndexedData> data = indexResolver.resolveIndexesFor(keySpace, pUpdate.getPropertyPath(),
 					targetProperty.getTypeInformation(), pUpdate.getValue());
@@ -586,8 +577,7 @@ RedisPersistentProperty getTargetPropertyOrNullForPath(String path, Class<?> typ
 			PersistentPropertyPath<RedisPersistentProperty> persistentPropertyPath = mappingContext
 					.getPersistentPropertyPath(path, type);
 			return persistentPropertyPath.getLeafProperty();
-		} catch (Exception ignore) {
-		}
+		} catch (Exception ignore) {}
 
 		return null;
 	}
@@ -694,7 +684,7 @@ private ReferenceResolver getRequiredReferenceResolver() {
 
 		Assert.notNull(referenceResolver, "ReferenceResolver must not be null");
 		return referenceResolver;
-    }
+	}
 
 	private void writeAssociation(String path, RedisPersistentEntity<?> entity, @Nullable Object value, RedisData sink) {
 
@@ -822,7 +812,8 @@ private void writeToBucket(String path, @Nullable Object value, RedisData sink,
 	}
 
 	@SuppressWarnings("NullAway")
-	private @Nullable Object readCollectionOrArray(String path, Class<?> collectionType, Class<?> valueType, Bucket bucket) {
+	private @Nullable Object readCollectionOrArray(String path, Class<?> collectionType, Class<?> valueType,
+			Bucket bucket) {
 
 		List<String> keys = new ArrayList<>(bucket.extractAllKeysFor(path));
 		keys.sort(listKeyComparator);
@@ -991,7 +982,7 @@ private Class<?> getTypeHint(String path, Bucket bucket, Class<?> fallback) {
 	 * @return
 	 * @throws ConverterNotFoundException
 	 */
-	public byte@Nullable[] toBytes(Object source) {
+	public byte @Nullable [] toBytes(Object source) {
 
 		if (source instanceof byte[] bytes) {
 			return bytes;

src/test/java/org/springframework/data/redis/core/convert/MappingRedisConverterUnitTests.java

@@ -66,12 +66,9 @@
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.EnabledOnJre;
-import org.junit.jupiter.api.condition.JRE;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-
 import org.springframework.core.convert.converter.Converter;
 import org.springframework.data.convert.ReadingConverter;
 import org.springframework.data.convert.WritingConverter;
@@ -1998,7 +1995,6 @@ void readGenericEntity() {
 	}
 
 	@Test // GH-2168
-//	@EnabledOnJre(JRE.JAVA_8)
 	void writePlainList() {
 
 		List<Object> source = Arrays.asList("Hello", "stream", "message", 100L);