Skip to content

Commit d966f61

Browse files
committed
Nullability improvements in DefaultKafkaConsumerFactory
Signed-off-by: Soby Chacko <[email protected]>
1 parent 05d6494 commit d966f61

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaConsumerFactory.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
* @author Yaniv Nahoum
7777
* @author Sanghyeok An
7878
* @author Borahm Lee
79+
* @author Soby Chacko
7980
*/
8081
public class DefaultKafkaConsumerFactory<K, V> extends KafkaResourceFactory
8182
implements ConsumerFactory<K, V>, BeanNameAware, ApplicationContextAware {
@@ -88,9 +89,9 @@ public class DefaultKafkaConsumerFactory<K, V> extends KafkaResourceFactory
8889

8990
private final List<ConsumerPostProcessor<K, V>> postProcessors = new ArrayList<>();
9091

91-
private @Nullable Supplier<Deserializer<K>> keyDeserializerSupplier;
92+
private @Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier;
9293

93-
private @Nullable Supplier<Deserializer<V>> valueDeserializerSupplier;
94+
private @Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier;
9495

9596
private String beanName = "not.managed.by.Spring";
9697

@@ -148,8 +149,8 @@ public DefaultKafkaConsumerFactory(Map<String, Object> configs,
148149
* @since 2.3
149150
*/
150151
public DefaultKafkaConsumerFactory(Map<String, Object> configs,
151-
@Nullable Supplier<Deserializer<K>> keyDeserializerSupplier,
152-
@Nullable Supplier<Deserializer<V>> valueDeserializerSupplier) {
152+
@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier,
153+
@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier) {
153154

154155
this(configs, keyDeserializerSupplier, valueDeserializerSupplier, true);
155156
}
@@ -166,8 +167,8 @@ public DefaultKafkaConsumerFactory(Map<String, Object> configs,
166167
* @since 2.8.7
167168
*/
168169
public DefaultKafkaConsumerFactory(Map<String, Object> configs,
169-
@Nullable Supplier<Deserializer<K>> keyDeserializerSupplier,
170-
@Nullable Supplier<Deserializer<V>> valueDeserializerSupplier, boolean configureDeserializers) {
170+
@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier,
171+
@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier, boolean configureDeserializers) {
171172

172173
this.configs = new ConcurrentHashMap<>(configs);
173174
this.configureDeserializers = configureDeserializers;
@@ -207,7 +208,7 @@ public void setValueDeserializer(@Nullable Deserializer<V> valueDeserializer) {
207208
* @param keyDeserializerSupplier the supplier.
208209
* @since 2.8
209210
*/
210-
public void setKeyDeserializerSupplier(Supplier<Deserializer<K>> keyDeserializerSupplier) {
211+
public void setKeyDeserializerSupplier(@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier) {
211212
this.keyDeserializerSupplier = keyDeserializerSupplier;
212213
}
213214

@@ -218,7 +219,7 @@ public void setKeyDeserializerSupplier(Supplier<Deserializer<K>> keyDeserializer
218219
* @param valueDeserializerSupplier the supplier.
219220
* @since 2.8
220221
*/
221-
public void setValueDeserializerSupplier(Supplier<Deserializer<V>> valueDeserializerSupplier) {
222+
public void setValueDeserializerSupplier(@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier) {
222223
this.valueDeserializerSupplier = valueDeserializerSupplier;
223224
}
224225

@@ -245,12 +246,12 @@ public Map<String, Object> getConfigurationProperties() {
245246
}
246247

247248
@Override
248-
public Deserializer<K> getKeyDeserializer() {
249+
public @Nullable Deserializer<K> getKeyDeserializer() {
249250
return Objects.requireNonNull(this.keyDeserializerSupplier).get();
250251
}
251252

252253
@Override
253-
public Deserializer<V> getValueDeserializer() {
254+
public @Nullable Deserializer<V> getValueDeserializer() {
254255
return Objects.requireNonNull(this.valueDeserializerSupplier).get();
255256
}
256257

0 commit comments

Comments
 (0)