Invalid sub-module dependencies #1441
Unanswered
mschaeferjelli
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, I'm trying to slowly clean up a poorly architected monolith. I started by identifying three basic modules of functionality and bucketing Services into those modules. I'm getting
Invalid sub-module referenceI have "audience", "inventory" and "planner" and InventoryService within inventory that sends an event when inventory changes
So, "inventory" -> "audience" and "planner" -> "inventory","audience"
and "planner.healer"->"inventory.inventoryservice" -- this causes the invalid sub-module reference.
Is there an opinionated reason that this is invalid? I'd prefer to have general protection against "inventory"->"planner" which I don't think I can get without the outer modules. For example, "planservice" -> "inventoryservice" -> "planupdateservice" would pass architectural verification and would require a human to catch in a PR even though it's planner->inventory->planner
Beta Was this translation helpful? Give feedback.
All reactions