Refactor select query builder to ensure join select clause is only included when not empty

Author: kingRayhan

__tests__/repository/find-row.test.ts

@@ -1,8 +1,12 @@
 import { Repository } from "../../src/repository/repository";
 import { eq, and, gt, like } from "../../src";
-import {executor, setupTestTables, cleanupTestData, seedTestData, DomainUser} from "../../test-setup";
-
-
+import {
+  executor,
+  setupTestTables,
+  cleanupTestData,
+  seedTestData,
+  DomainUser,
+} from "../../test-setup";
 
 describe("Repository findRow", () => {
   let repository: Repository<DomainUser>;
@@ -34,7 +38,9 @@ describe("Repository findRow", () => {
   });
 
   it("should return null when no row is found", async () => {
-    const result = await repository.findRow(eq("email", '[email protected]'));
+    const result = await repository.findRow(
+      eq("email", "[email protected]")
+    );
     expect(result).toBeNull();
   });
 

__tests__/repository/join.test.ts

@@ -84,7 +84,7 @@ export class SelectQueryBuilder<T> extends BaseQueryBuilder<T> {
 
     const sql = `
       SELECT ${columns}
-      ${joinSelectClause ? `,${joinSelectClause.join(",")}` : ""}
+      ${joinSelectClause.length > 0 ? `,${joinSelectClause.join(",")}` : ""}
       FROM "${this.tableName}"
       ${joinConditionClause ? joinConditionClause : ""}
       ${whereClause ? `WHERE ${whereClause}` : ""}