Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] uninitialized status lead to erroneous logic #6

Open
NeutrinoLiu opened this issue Sep 12, 2023 · 0 comments
Open

[bug] uninitialized status lead to erroneous logic #6

NeutrinoLiu opened this issue Sep 12, 2023 · 0 comments

Comments

@NeutrinoLiu
Copy link

NeutrinoLiu commented Sep 12, 2023

UPDATE:

Seems all because i add libmmwave as the library dependency

build_example(
  NAME wns3-mpquic-two-path
  SOURCE_FILES wns3-mpquic-two-path.cc
  LIBRARIES_TO_LINK
    ${libmmwave}
    ${libquic}
)

Once i added it, instantiated objects in mpquic are not fully initialized. (bool members are of random init values)


PREVIOUS POST:

plz initiate m_appCloseSentListNoEmpty explicitly with false at

int m_appCloseSentListNoEmpty;

or it will lead to erroneous logic at the very first execution of
if (m_appCloseSentListNoEmpty && m_txBuffer->SentListIsEmpty()){

reproduce erroneous logic: add libmmwave to the link library in cmakelist for wns3-mpquic-two-path target.

also the running result is inconsistent between adding mmwave lib and running without mmwave lib with an identical rand seed. One of the reason is above mentioned uninit status. but two runs still output differently even after fixing above bug (cwnd of path1 diverges halfway). It will be better if you could figure out why this happens. running single path do show identical results w or w/o mmwave lib enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant