Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License file not found for notify:5.1.0 #13

Open
dergecko opened this issue Apr 3, 2023 · 1 comment
Open

License file not found for notify:5.1.0 #13

dergecko opened this issue Apr 3, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dergecko
Copy link

dergecko commented Apr 3, 2023

For the crate notify the license is not correctly added to the bundled file.

Instead of copying the license file bundle-licenses just posts the string path into the licenses text field:

  - package_name: notify
    package_version: 5.1.0
    license: CC0-1.0 OR Artistic-2.0
    licenses:
      - license: CC0-1.0
        text: "../LICENSE"
      - license: Artistic-2.0
        text: "../LICENSE"

The license file in the repo is a symbolic link to the parent dir.

If you need further information feel free to reach out to me.

@sstadick
Copy link
Owner

sstadick commented Apr 5, 2023

Thanks for making an issue!

The short of it is that notify is using a workspace and symlinking the license files from the workspace dir into the individual crate directories. This is related to #2, which is also not fully resolved.

For now I'd recommend just manually pasting the text in as specified in the README. Next time I'm doing work on this I'll revisit this set of issues.

@sstadick sstadick added the bug Something isn't working label Apr 5, 2023
@sstadick sstadick self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants