Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is a bit unclear on how to deal with workspaces #38

Open
BatmanAoD opened this issue Nov 8, 2024 · 1 comment
Open

Documentation is a bit unclear on how to deal with workspaces #38

BatmanAoD opened this issue Nov 8, 2024 · 1 comment

Comments

@BatmanAoD
Copy link

The README says:

The most common cause of missing licenses seems to be workspaces that don't include forward their license files. Go to the repo for the workspace and copy the relevant files from there.

I'm not sure what "include forward their license files" means here. Is this talking about workspace projects that have multiple crates with a shared repo and a single license file for the whole repo? What is "include forwarding"? Can the tool just find the "workspace root" somehow and get the license that way?

@BatmanAoD
Copy link
Author

BatmanAoD commented Nov 8, 2024

...possibly related, and probably a bug (though apparently a cargo one rather than a bundle-licenses one): it looks like, if the license file is a symlink, the generated "license text" is the actual symlink pointer. So, for instance, nalgebra-macros uses a symlink pointing to ../LICENSE: https://github.com/dimforge/nalgebra/tree/main/nalgebra-macros

...but the license text generated by bundel-licenses is the literal string ../LICENSE. (In fact, it seems that the symlink is actually "flattened" into a normal file by cargo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant