Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen dependencies requirements #341

Open
Zaczero opened this issue Jan 24, 2025 · 1 comment · May be fixed by #342
Open

Loosen dependencies requirements #341

Zaczero opened this issue Jan 24, 2025 · 1 comment · May be fixed by #342

Comments

@Zaczero
Copy link

Zaczero commented Jan 24, 2025 •
edited
Loading

https://github.com/stac-utils/pgstac/blob/main/src/pypgstac/pyproject.toml

Such pinning makes it impossible to integrate this tool into other projects (without hacky workarounds like override-dependencies, forceful dependency overrides). And I assume the intention is to allow such use cases given the existence of py.typed file which otherwise would be redundant.

There exist online resources on this topic: https://discuss.python.org/t/should-i-be-pinning-my-dependencies/13159

A popular and good practice is to use >= for defining your dependencies.
@hrodmn
Copy link
Collaborator

hrodmn commented Jan 24, 2025

Hi @Zaczero - thanks for opening the issue. I appreciate the challenges that the strict dependency requirements might impose on using pypgstac within a larger project, but I have not run into that recently. Is there a particular dependency that is causing the problem in your case?

Feel free to open a pull request with the changes you described! It might be fine to open everything up with >= but I suspect there is a reason at least some of them have been pinned to specific versions.

Zaczero added a commit to Zaczero/pgstac that referenced this issue Jan 27, 2025
@Zaczero
Loosen dependencies requirements stac-utils#341
29bced8 
Also remove unused packages: flake8, types-setuptools
@Zaczero Zaczero linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typing improvements and loosened dependencies Zaczero/pgstac
2 participants
@Zaczero @hrodmn