Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put alembic code inside Python package? #30

Open
kylebarron opened this issue Jan 29, 2021 · 1 comment
Open

Put alembic code inside Python package? #30

kylebarron opened this issue Jan 29, 2021 · 1 comment

Comments

@kylebarron
Copy link
Contributor

Would it make sense to put the alembic dir within stac_api as a Python module? Then downstream libraries could have access to that without copying files from the repo.

@geospatial-jeff
Copy link
Collaborator

I am a fan of including the alembic migrations with the python module but not a fan of what you are proposing with respect to the current state of the repo.

Currently there is a bunch of postgres related code in this repo (migrations, data models etc.) but that is only because we've been building the API using postgres as the "canonical" backend. In the future, the goal is to have this repo just contain the STAC-compliant API layer and respective base classes, with any backend specific code living somewhere else.

The library is constructed as is (backend code + api layer in same place) for ease of initial development, but we are quickly approaching a point where it is healthier to separate the two because it promotes better separation of concerns (#74 was a big step in this direction), at which point it makes sense to ship the default alembic migration with the backend code.

@gadomski gadomski transferred this issue from stac-utils/stac-fastapi May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants