Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log message needed when updating an existing collection record #830

Open
jkeifer opened this issue Feb 20, 2025 · 0 comments
Open

Comments

@jkeifer
Copy link
Member

jkeifer commented Feb 20, 2025

Updating a collection record via ingest currently produces an error log message that seems to indicate that something went wrong. That message is like {"level":"error","message":"$COLLECTION already exists."}. I believe to most people this message would indicate that the update failed, but that is not the case.

The message is emitted here. It indicates that the index for a given collection already exists and thus there is no attempt to create it. I do not believe this case to be an error, but more informational or perhaps even debug-level. I also think the message is problematically vague, and should be explicit like "index for collection {} already exists, skipping creation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant