Add vMCP e2e tests for tool overrides and composite workflows #2826
+986
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three new e2e test files for VirtualMCPServer: - virtualmcp_aggregation_overrides_test.go: Tests tool renaming via overrides configuration, verifying renamed tools appear with custom names and descriptions while original names are hidden. - virtualmcp_composite_sequential_test.go: Tests sequential composite tool workflows with template expansion, where step B depends on step A's output using Go template syntax. - virtualmcp_composite_parallel_test.go: Tests parallel composite workflows where independent steps execute concurrently before aggregating results in a final dependent step. All tests use yardstick as a deterministic MCP server backend. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
=======================================
Coverage 56.59% 56.59%
=======================================
Files 320 320
Lines 30899 30899
=======================================
Hits 17487 17487
Misses 11910 11910
Partials 1502 1502 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The filtering logic applies after tool overrides, so the filter must specify the renamed tool name (user-facing name) rather than the original name. Updated test to filter by renamedToolName. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
size/L
jhrozek
approved these changes
Dec 2, 2025
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I'll send a minor fixup as a follow up but tests are always good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
virtualmcp_aggregation_overrides_test.go- tests tool renaming via overridesvirtualmcp_composite_sequential_test.go- tests sequential A→B workflows with template expansionvirtualmcp_composite_parallel_test.go- tests parallel step execution with fan-out/fan-in DAGAll tests use yardstick as a deterministic MCP server backend.
Test plan
golangci-lint run ./test/e2e/thv-operator/virtualmcp/...🤖 Generated with Claude Code