Add log level configuration support to VirtualMCPServer #2837
+82
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds LogLevel field to VirtualMCPServer CRD OperationalConfig to allow configuring the logging level for vMCP instances. Supports info, debug, warn, and error levels with info as the default. The deployment builder now passes the --log-level flag to the vmcp container based on the CRD configuration. When not specified, defaults to info level to ensure consistent logging behavior. Fixes stacklok#2781 Signed-off-by: 4t8dd <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
+ Coverage 56.61% 56.62% +0.01%
==========================================
Files 320 320
Lines 30932 30937 +5
==========================================
+ Hits 17511 17518 +7
+ Misses 11916 11914 -2
Partials 1505 1505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jhrozek should I bump the crd version as show from the CI ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds LogLevel field to VirtualMCPServer CRD OperationalConfig to allow configuring the logging level for vMCP instances. Supports info, debug, warn, and error levels with info as the default.
The deployment builder now passes the --log-level flag to the vmcp container based on the CRD configuration. When not specified, defaults to info level to ensure consistent logging behavior.
Fixes #2781